-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2484 Used restrict_derivation() with AVISITN > 0 to restrict CHG and PCHG to post-baseline records #2488
Merged
bms63
merged 14 commits into
main
from
2484-general-issue-chg-and-pchg-populated-for-baseline-and-pre-baseline-records-in-the-templates
Sep 3, 2024
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f2aa08e
Used restrict_derivation() with AVISITN > 0 to restrict CHG and PCHG …
steventing12 fe981f5
Merge branch 'main' into 2484-general-issue-chg-and-pchg-populated-fo…
steventing12 93be737
feat: #2484 updated comments for CHG and PCHG
steventing12 c7e8893
feat: #2484 Manually added "Rothstein" to inst/WORDLIST
steventing12 406af67
Merge branch '2484-general-issue-chg-and-pchg-populated-for-baseline-…
steventing12 d372084
feat: #2484 Updated CHG/PCHG comments and restrict_derivation call to…
steventing12 cb2dedf
Merge branch 'main' into 2484-general-issue-chg-and-pchg-populated-fo…
steventing12 3fe0297
feat: #2484 Changed 'sponsor' to 'producer'
steventing12 0bbbe41
feat: #2484 Use restrict_derivation() with filter AVISITN > 0 to deri…
steventing12 666ec23
Merge branch 'main' into 2484-general-issue-chg-and-pchg-populated-fo…
steventing12 6e1f83e
Merge branch 'main' into 2484-general-issue-chg-and-pchg-populated-fo…
steventing12 d4ec9ee
Merge branch 'main' into 2484-general-issue-chg-and-pchg-populated-fo…
steventing12 c5c09f1
feat: #2484 Run style_file()
steventing12 56acd48
feat: #2484 Add piping back to derive_var_obs_number() for adgdssf da…
steventing12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -315,6 +315,7 @@ repo | |
reproducibility | ||
rlang | ||
roche | ||
Rothstein | ||
roxygen | ||
scalable | ||
signif | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sponsor rather than producer should be used. What do you think? If agree can you update the other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think producer is a more inclusive term (e.g. CROs are typically vendors, not sponsors) but happy to change if all agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure producer sounds good.