Closes #2484 Used restrict_derivation() with AVISITN > 0 to restrict CHG and PCHG to post-baseline records #2488
Conversation
…derivations to post-baseline observations. Note that NA visit changes are also not derived.
…r-baseline-and-pre-baseline-records-in-the-templates
|
|
Do any of the vignettes need to be updated as well? @Fanny-Gautier do you mind looking at this as well? |
|
As commented by Nancy, maybe the update of the comment only in the template would be sufficient to clarify as per ADaM IG that "The decision on how to populate pre-baseline and baseline values of CHG is left to producer choice." / "The decision on how to populate pre-baseline and baseline values of PCHG is left to producer choice." |
…and-pre-baseline-records-in-the-templates' of github.com:pharmaverse/admiral into 2484-general-issue-chg-and-pchg-populated-for-baseline-and-pre-baseline-records-in-the-templates
|
@steventing12, it has been discussed during the {admiral} core dev team meeting:
|
|
@Fanny-Gautier Thanks for the update Fanny, I will apply the requested changes. |
… notify that as per ADaM IG, the decision on how to populate pre-baseline and baseline values of CHG/PCHG is left to producer choice.
…r-baseline-and-pre-baseline-records-in-the-templates
| # Calculate PCHG | ||
| derive_var_pchg() | ||
| # Calculate CHG for post-baseline records | ||
| # The decision on how to populate pre-baseline and baseline values of CHG is left to producer choice |
There was a problem hiding this comment.
| # The decision on how to populate pre-baseline and baseline values of CHG is left to producer choice | |
| # The decision on how to populate pre-baseline and baseline values of CHG is left to the sponsor. | |
| We have chosen to not populate pre-baseline records. |
I think sponsor rather than producer should be used. What do you think? If agree can you update the other comments.
There was a problem hiding this comment.
I think producer is a more inclusive term (e.g. CROs are typically vendors, not sponsors) but happy to change if all agree.
There was a problem hiding this comment.
sure producer sounds good.
| # The decision on how to populate pre-baseline and baseline values of CHG is left to producer choice | |
| # The decision on how to populate pre-baseline and baseline values of CHG is left to the producer. |
|
Can you check the vignettes as well? I believe some updates will be needed there as well. We try and keep them aligned as much as possible. |
Sure, will do. |
Following up, there was one other instance of 'sponsor' used in inst/templates/ad_adcm.R, line 92. The term 'producer' does not appear in the vignettes. I can change in ad_adcm.R to producer as well. |
Sounds good!! |
|
The Links issue is being fixed in another PR FYI |
…ve CHG and PCHG for post-baseline records only
…r-baseline-and-pre-baseline-records-in-the-templates
…r-baseline-and-pre-baseline-records-in-the-templates
…r-baseline-and-pre-baseline-records-in-the-templates
There was a problem hiding this comment.
Updated CHG and PCHG derivations with restrict_derivation() for only post-baseline records with corresponding comment: "The decision on how to populate pre-baseline and baseline values of CHG is left to producer choice." / "The decision on how to populate pre-baseline and baseline values of PCHG is left to producer choice."
Applied to
o inst/templates/ ad_advs.R, ad_adeg.R, ad_adlb.R, ad_adpc.R
o vignettes/ bds_finding.Rmd, pk_adnca.Rmd, questionnaries.Rmd
Also changed 'sponsor' comment to 'producer' in ad_adcm
bms63
deleted the
2484-general-issue-chg-and-pchg-populated-for-baseline-and-pre-baseline-records-in-the-templates
branch
…derivations to post-baseline observations. Note that NA visit changes are also not derived.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()