Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2147 addressing cran failure #2149

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Closes #2147 addressing cran failure #2149

merged 3 commits into from
Oct 4, 2023

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented Oct 3, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4419 / 4489)

regexp = paste(
paste(
"The input dataset does not contain any observations fullfiling the filter",
"condition (NULL) for the parameter codes (PARAMCD) `HEIGHT`"
Copy link
Collaborator Author

@zdz2101 zdz2101 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Background:

  • One of R version 4.4's biggest changes is that is.atomic(NULL) now returns FALSE, it currently returns TRUE.
  • In our codebase, for get_hori_data() which is used for derive_param_computed(), in the section that creates warning messaging, we use a function from rlang::expr_label() to assist us with the aesthetically pleasing looking warning messages.
  • expr_label() is currently under the lifecycle's "questioning" label which means rlang themselves had thoughts of: "a function is no longer certain that a function is the optimal approach, but doesn’t yet know how to do it better"
  • We would just need to add ticks around NULL to fix/make sure the test passes for 4.4 but it would break the tests for <=4.3
  • For the purpose of our code/test in this case its really no big deal, I suggest we just lighten up the restriction not to string match the entire warning message, and just the part that says: "The input dataset does not contain any observations fullfiling the filter" so that it would continue to work for all versions
  • The messaging of this warning in the future would now encase NULL in ticks vs prior to 4.4 it did not

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pharmaverse/admiral

@bms63
Copy link
Collaborator

bms63 commented Oct 4, 2023

We will need to upversion the DESCRIPTION File and make a news blurb.

@zdz2101 zdz2101 requested a review from bms63 October 4, 2023 15:30
@zdz2101 zdz2101 linked an issue Oct 4, 2023 that may be closed by this pull request
@bms63 bms63 merged commit 9bcb396 into patch Oct 4, 2023
19 checks passed
@bms63 bms63 deleted the 2147_failed_cran_checks branch October 4, 2023 18:06
bms63 added a commit that referenced this pull request Oct 6, 2023
…hecks (#2157)

* Closes #2147 addressing cran failure (#2149)

* feat: #2147 one solution but proceed with caution

* description uplevel and news blurb

* pass links?

---------

Co-authored-by: Zelos Zhu <[email protected]>

* Update README.md (#2155)

* Update README.md

* URL update

---------

Co-authored-by: Daniel Sjoberg <[email protected]>

---------

Co-authored-by: Zelos Zhu <[email protected]>
Co-authored-by: Zelos Zhu <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>
bms63 added a commit that referenced this pull request Oct 19, 2023
* Closes #2147 addressing cran failure (#2149)

* feat: #2147 one solution but proceed with caution

* description uplevel and news blurb

* pass links?

---------

Co-authored-by: Zelos Zhu <[email protected]>

* Update README.md (#2155)

* Update README.md

* URL update

---------

Co-authored-by: Daniel Sjoberg <[email protected]>

* Closes #2154 fix_dthcaus: fix derive_var_dthcaus() (#2162)

* #2154 fix_dthcaus: fix derive_var_dthcaus()

* #2154 fix_dthcaus: run templates check

* #2154 fix_dthcaus: update version number and NEWS

* docs: fixing curlys after feedback from CRAN

* chore: styling death test

---------

Co-authored-by: Zelos Zhu <[email protected]>
Co-authored-by: Zelos Zhu <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Stefan Bundfuss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URGENT! Failed CRAN Checks: 2023-10-02
2 participants