-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2147 addressing cran failure #2149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdz2101
commented
Oct 3, 2023
regexp = paste( | ||
paste( | ||
"The input dataset does not contain any observations fullfiling the filter", | ||
"condition (NULL) for the parameter codes (PARAMCD) `HEIGHT`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background:
- One of R version 4.4's biggest changes is that
is.atomic(NULL)
now returnsFALSE
, it currently returnsTRUE
. - In our codebase, for
get_hori_data()
which is used forderive_param_computed()
, in the section that creates warning messaging, we use a function fromrlang::expr_label()
to assist us with the aesthetically pleasing looking warning messages. expr_label()
is currently under the lifecycle's"questioning"
label which meansrlang
themselves had thoughts of: "a function is no longer certain that a function is the optimal approach, but doesn’t yet know how to do it better"- We would just need to add ticks around NULL to fix/make sure the test passes for 4.4 but it would break the tests for <=4.3
- For the purpose of our code/test in this case its really no big deal, I suggest we just lighten up the restriction not to string match the entire warning message, and just the part that says: "The input dataset does not contain any observations fullfiling the filter" so that it would continue to work for all versions
- The messaging of this warning in the future would now encase
NULL
in ticks vs prior to 4.4 it did not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pharmaverse/admiral
We will need to upversion the DESCRIPTION File and make a news blurb. |
bms63
approved these changes
Oct 4, 2023
bms63
added a commit
that referenced
this pull request
Oct 6, 2023
…hecks (#2157) * Closes #2147 addressing cran failure (#2149) * feat: #2147 one solution but proceed with caution * description uplevel and news blurb * pass links? --------- Co-authored-by: Zelos Zhu <[email protected]> * Update README.md (#2155) * Update README.md * URL update --------- Co-authored-by: Daniel Sjoberg <[email protected]> --------- Co-authored-by: Zelos Zhu <[email protected]> Co-authored-by: Zelos Zhu <[email protected]> Co-authored-by: Daniel Sjoberg <[email protected]>
bms63
added a commit
that referenced
this pull request
Oct 19, 2023
* Closes #2147 addressing cran failure (#2149) * feat: #2147 one solution but proceed with caution * description uplevel and news blurb * pass links? --------- Co-authored-by: Zelos Zhu <[email protected]> * Update README.md (#2155) * Update README.md * URL update --------- Co-authored-by: Daniel Sjoberg <[email protected]> * Closes #2154 fix_dthcaus: fix derive_var_dthcaus() (#2162) * #2154 fix_dthcaus: fix derive_var_dthcaus() * #2154 fix_dthcaus: run templates check * #2154 fix_dthcaus: update version number and NEWS * docs: fixing curlys after feedback from CRAN * chore: styling death test --------- Co-authored-by: Zelos Zhu <[email protected]> Co-authored-by: Zelos Zhu <[email protected]> Co-authored-by: Daniel Sjoberg <[email protected]> Co-authored-by: Stefan Bundfuss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()