Closes #2147 addressing cran failure (#2149)

* feat: #2147 one solution but proceed with caution * description uplevel and news blurb * pass links? --------- Co-authored-by: Zelos Zhu <[email protected]>
pharmaverse · Oct 4, 2023 · 9bcb396 · 9bcb396
1 parent d038895
commit 9bcb396
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: admiral
 Type: Package
 Title: ADaM in R Asset Library
-Version: 0.12.1
+Version: 0.12.2
 Authors@R: c(
     person("Ben", "Straub", email = "[email protected]", role = c("aut", "cre")),
     person("Stefan", "Bundfuss", role = "aut"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# admiral 0.12.2
+
+- A unit test for `derive_param_computed()` was modified in anticipation of major user-facing changes to R version 4.4 (#2147)
+
 # admiral 0.12.1
 
 - `derive_extreme_records()` no longer fails if `dataset_add` is specified and a

diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ Phases:
 | Q4-2023          | December 4th                                                             | December 11th                                                        |
 |                  | [{pharmaversesdtm}](https://pharmaverse.github.io/pharmaversesdtm/main/) | [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/)     |
 |                  | [{admiraldev}](https://pharmaverse.github.io/admiraldev/main/)           | [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/) |
-|                  | [{admiral}](https://pharmaverse.github.io/admiral/main/)                 |                                                                      |
+|                  | [{admiral}](https://pharmaverse.github.io/admiral)                 |                                                                      |
 
 The `{admiral}` Q4-2023 release will officially be `{admiral}`'s version 1.0.0 release, where we commit to increased package maturity and pivot towards focusing on maintenance rather than new content. This does not mean that there will never be any new content in `{admiral}`, rather it means we will be more mindful about introducing new functionality and/or breaking changes. The release schedule in 2024 and onward will also shift to twice-yearly, rather than quarterly, so that our users have ample time to react to any new content and changes that do make it onto `{admiral}`.
 

diff --git a/tests/testthat/test-derive_param_computed.R b/tests/testthat/test-derive_param_computed.R
@@ -343,15 +343,7 @@ test_that("derive_param_computed Test 8: no new observations if a constant param
         AVALU = "kg/m2"
       )
     ),
-    regexp = paste(
-      paste(
-        "The input dataset does not contain any observations fullfiling the filter",
-        "condition (NULL) for the parameter codes (PARAMCD) `HEIGHT`"
-      ),
-      "No new observations were added.",
-      sep = "\n"
-    ),
-    fixed = TRUE
+    regexp = "The input dataset does not contain any observations fullfiling the filter"
   )
 
   expect_dfs_equal(