-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some plpgsql errors #244
Open
MGorkov
wants to merge
8
commits into
pganalyze:16-latest
Choose a base branch
from
MGorkov:master
base: 16-latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGorkov
changed the title
fix ival for negatives and zeroes
fix ival for negatives and zeros
Apr 16, 2024
Thanks for the patch, and conceptually looks good! However it appears there is a problem with the I believe this is actually a larger issue with how we handle |
MGorkov
force-pushed
the
master
branch
3 times, most recently
from
May 7, 2024 14:58
53a97cc
to
56d91d3
Compare
- variable "$1" does not exist - collations are not supported by type - - variable "ref" must be of type cursor or refcursor
…TURN NEXT with no expression
msullivan
added a commit
to msullivan/libpg_query
that referenced
this pull request
May 9, 2024
Currently the value of negative constants are omitted. Only omit *0* constants. An earlier attempt (pganalyze#244) caused a mismatch with the protobuf json output, since that wants to omit values that are equal to the default value. I don't *really* think that is particularly sensible behavior for an integer constant in an AST, but oh well. Fixes pganalyze#243.
msullivan
added a commit
to msullivan/libpg_query
that referenced
this pull request
May 9, 2024
Currently the value of negative constants are omitted. Only omit *0* constants. An earlier attempt (pganalyze#244) caused a mismatch with the protobuf json output, since that wants to omit values that are equal to the default value. I don't *really* think that is particularly sensible behavior for an integer constant in an AST, but oh well. Fixes pganalyze#243.
msullivan
added a commit
to msullivan/libpg_query
that referenced
this pull request
May 9, 2024
Currently the value of negative constants are omitted. Only omit *0* constants. An earlier attempt (pganalyze#244) caused a mismatch with the protobuf json output, since that wants to omit values that are equal to the default value. I don't *really* think that is particularly sensible behavior for an integer constant in an AST, but oh well. Fixes pganalyze#243.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the #243 , #160 , #248 issues and the following errors:
"variable "$1" does not exist"
"collations are not supported by type -"
"variable "ref" must be of type cursor or refcursor"
missing expression at or near ";"
changes in JSON: