Additional PL/pgSQL parsing fixes #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as records This ensures the PL/pgSQL lexer detects variable references to such variables as variables, instead of erroring out with "[var.name] is not a known variable". The trade-off here is that we might incorrectly detect custom data types registered outside of pg_catalog as being records, instead of data types.
…references This makes sure function bodies that contain ALIAS FOR statements to rename positional references like $1 get parsed correctly, instead of erroring out with "variable "$1" does not exist".
…param_varno This ensures functions with statements like "RETURN NEXT;" or "RETURN;" don't error out.
This requires the data type parsing to correctly set the collation field, which for now we do when the type is defined as "text". In passing we also adjust the hardcoded collection in get_collation_oid to use DEFAULT_COLLATION_OID (100), which seems better than using -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages. Some of this based on work by @MGorkov in #244 - this PR (mostly) supersedes that PR. Note there were some changes there that modified the parse structs that I didn't carry over, since they are not directly related to parsing errors.
Fixes #160, #248, #260.