-
Notifications
You must be signed in to change notification settings - Fork 0
Create Dummy ROS2 Nodes for MoveAbovePlate, Integrates into App #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bffa484
to
564644c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything ran great the first time, letting MoveAbovePlate run unpaused to the end. I ran into this error after both pausing and refreshing the page before MoveAbovePlate was completed. Both of these caused MoveAbovePlate to cancel and restart, but when the action was completed it moved to a blank screen. Now, when I restart the app using npm start, it begins MoveAbovePlate and then proceeds to the blank screen.
Hmm, I am not sure what caused that error. I just tried: (1) running it normally; (2) pausing and resuming; (3) pausing then refreshing; (4) refreshing then pausing; (5) pausing then resuming then refreshing. It all moved to the next state as expected. @taylorkf can you try the following:
(The errors in rclpy are errors I've seen before, I think it is due to the fact that rosbridge_websocket doesn't officially support ROS actions. I've never had that error affect functionality though.) |
Ok, after testing multiple times, it appears that on my computer this breaks with a refresh at any point in time. The links trace the error to the shown line of code. From a brief google, it seems that this may be due to an unused useState? (https://stackoverflow.com/questions/53472795/uncaught-error-rendered-fewer-hooks-than-expected-this-may-be-caused-by-an-acc) |
It looks like you are using old code -- see MovingAbovePlate on the branch associated with this PR. Your screenshot shows an extra line that gets Can you pull again and re-build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I added a few comments that don't need to be addressed in this PR, just general info.
- Implemented and tested the MoveAbovePlate dummy ROS action - Integrated it with the web app and thoroughly tested it - Made the Footer take in paused/setPaused and callback functions from the page it is on - Updated README
92427d8
to
c74490c
Compare
[Describe this pull request. Link to relevant GitHub issues, if any.]
In service of #27 .
This PR does the following:
MoveAbovePlate
. This dummy action sleeps for 2.5 secs during planning, and 10 secs during motion.pause
state and pause/resume callbacks from the main app page, as opposed to creating it locally in that component.[Explain how this pull request was tested, including but not limited to the below checkmarks.]
I first tested the ROS Action in isolation, by ensuring that it behaved as expected when:
success==false
). (Should return planning failure.)success==false
). (Should return motion failure.)I then tested the web app's usage of the ROS action by, for the MoveAbovePlate page:
Before creating a pull request
npm run format
Before merging a pull request
Squash and Merge
)