-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Update dependencies and improve docs #21
Merged
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ee92172
chore: improve docs
ibakshay d6d9443
chore: update dependencies + go version
ibakshay 84f6914
chore: update makefile targets for generating YAML manifests and code
ibakshay 249615f
[ENHANCEMENT] get the operator up to date
ibakshay b84e3d2
[ENHANCEMENT] update perses crd
ibakshay cf893a2
[ENHANCEMENT] update makefile test targets
ibakshay 52e0948
[ENHANCEMENT] minor improvement
ibakshay 3069af5
[ENHANCEMENT] fix make test target
ibakshay 3499701
[ENHANCEMENT] increment controller gen version to v0.16.0
ibakshay d3bfaa3
[BUGFIX] fix panic when fetching dashbaords
ibakshay a5c8380
[ENHANCEMENT] update perses dependency
ibakshay 273fba2
update perses API dependency to fix duration types
jgbernalp 728b4be
Merge pull request #1 from jgbernalp/ibakshay-pr-21
ibakshay 4e2fa72
[ENHANCEMENT] efficient deepcopy
ibakshay bd49846
[IGNORE] fix linting issue
ibakshay 0a315a7
[IGNORE] dependency update
ibakshay 3849b48
[ENHANCEMENT] review comment fix
ibakshay 9847bb1
[ENHANCEMENT] Removed the unused client
ibakshay 1293ad7
[IGNORE] minor fix
ibakshay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for deep copy in the Perses repo we are using this package
github.com/brunoga/deep
. Works pretty well.Maybe it's more efficient than marshalling and unmarshalling the data 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the pointer, Augustin. I have manually marshalled and unmarshalled as I was getting issue during deepcopying using
go-deepcopy
library. The github.com/brunoga/deep works great and I have fixed in this commit 4e2fa72 :)