[ENHANCEMENT] Update dependencies and improve docs #21
Conversation
ibakshay
force-pushed
the
akshay/update-dependencies
branch
2 times, most recently
from
254f17c to
249f796
Compare
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
ibakshay
force-pushed
the
akshay/update-dependencies
branch
from
249f796 to
249615f
Compare
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
ibakshay
changed the title
|
@ibakshay thank you for your contribution!. Can you please take a look at the tests, they might need an update. |
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
My pleasure. Thanks a lot for your review. The test is failing due to this serialization issue. I have already created a PR in prometheus/common repository for the fix. The test should be successfully after PR in prometheus/common gets merged. |
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Gabriel Bernal <[email protected]>
update perses API dependency to fix duration types
| return nil, err | ||
| } | ||
| restClient, err := clientConfig.NewRESTClient(clientConfig.RestConfigClient{ | ||
| URL: &common.URL{URL: parsedURL.URL}, |
There was a problem hiding this comment.
| URL: &common.URL{URL: parsedURL.URL}, | |
| URL: parsedURL, |
There was a problem hiding this comment.
fixed in 4e2fa72 :)
| persesv1 "github.com/perses/perses/pkg/model/api/v1" | ||
| ) | ||
|
|
||
| type Dashboard struct { | ||
| persesv1.DashboardSpec `json:",inline"` | ||
| } | ||
|
|
||
| // DeepCopyInto is a manually implemented deep copy function and this is required because: | ||
| // 1. The embedded persesv1.DashboardSpec from the Perses project doesn't implement DeepCopyInto | ||
| // 2. controller-gen can't automatically generate DeepCopy methods for types it doesn't own | ||
| func (in *Dashboard) DeepCopyInto(out *Dashboard) { |
There was a problem hiding this comment.
for deep copy in the Perses repo we are using this package github.com/brunoga/deep. Works pretty well.
Maybe it's more efficient than marshalling and unmarshalling the data 🤔
There was a problem hiding this comment.
Thanks a lot for the pointer, Augustin. I have manually marshalled and unmarshalled as I was getting issue during deepcopying using go-deepcopy library. The github.com/brunoga/deep works great and I have fixed in this commit 4e2fa72 :)
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
|
|
||
| restClient, err := clientConfig.NewRESTClient(clientConfig.RestConfigClient{ | ||
| URL: &common.URL{URL: parsedURL.URL}, |
There was a problem hiding this comment.
| URL: &common.URL{URL: parsedURL.URL}, | |
| URL: parsedURL, |
There was a problem hiding this comment.
fixed in 3849b48 :)
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
| @@ -41,8 +54,13 @@ func NewWithURL(url string) PersesClientFactory { | |||
| } | |||
|
|
|||
| func (f *PersesClientFactoryWithURL) CreateClient(config persesv1alpha1.Perses) (v1.ClientInterface, error) { | |||
There was a problem hiding this comment.
Since this method doesn't use the config I guess we can remove it
There was a problem hiding this comment.
Sure! Removed in 9847bb1 commit :)
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
|
awesome. Thank you @ibakshay for your constant contribution around the perses-operator !! |
Changes
perses-server-urlflag for localhost testing:fixes #16 cloudoperators/greenhouse-extensions#419