Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe/useless 'use lib' from codebase #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove unsafe/useless 'use lib' from codebase #28

wants to merge 3 commits into from

Commits on Dec 20, 2018

  1. Add a basic Travis CI configuration file

    @atoomic
    atoomic committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    b143661 View commit details
    Browse the repository at this point in the history

  2. Add a basic .gitignore file 

    This is a draft, we can probably find
some extra entries to add there.
    @atoomic
    atoomic committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    0c7d0a5 View commit details
    Browse the repository at this point in the history

  3. Remove useless 'use lib' 

    Unit tests do not need to add 'use lib "lib"',
running 'prove -l' will automatically add it for you.

Concerning the two other scripts, it's unsafe to add 'lib'
to @inc, as this could result from loading .pm files from
any location. (depending from where the command is run and
which user is running it).

Once installed, it will use the default Perl @inc locations.
For development purpose, adding a -Ilib is probably better.

Using FindBin can be aceptable but also leaves a hole as the
lib directory might belong to a different user in production.
    @atoomic
    atoomic committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    1fd0143 View commit details
    Browse the repository at this point in the history