Remove unsafe/useless 'use lib' from codebase #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft, we can probably find some extra entries to add there.
Unit tests do not need to add 'use lib "lib"', running 'prove -l' will automatically add it for you. Concerning the two other scripts, it's unsafe to add 'lib' to @inc, as this could result from loading .pm files from any location. (depending from where the command is run and which user is running it). Once installed, it will use the default Perl @inc locations. For development purpose, adding a -Ilib is probably better. Using FindBin can be aceptable but also leaves a hole as the lib directory might belong to a different user in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this commit sit on top of the travis changes so I can be sure I'm not braking unit tests