Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13078 List available client versions #3077

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Jul 17, 2024

PMM-13078

Link to the Feature Build: SUBMODULES-3666

@ademidoff ademidoff changed the base branch from main to v3-api-breaking-changes July 17, 2024 15:28
@percona percona deleted a comment from it-percona-cla Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 74.50980% with 13 lines in your changes missing coverage. Please review.

Project coverage is 44.64%. Comparing base (0ac861d) to head (51dda8e).

Files Patch % Lines
managed/services/management/agent.go 74.00% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3077      +/-   ##
==========================================
+ Coverage   44.60%   44.64%   +0.04%     
==========================================
  Files         358      358              
  Lines       35575    35626      +51     
==========================================
+ Hits        15867    15907      +40     
- Misses      18092    18095       +3     
- Partials     1616     1624       +8     
Flag Coverage Δ
admin 11.52% <ø> (+0.05%) ⬆️
agent 52.74% <ø> (ø)
managed 46.84% <74.50%> (+0.06%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ademidoff added a commit to Percona-Lab/pmm-submodules that referenced this pull request Jul 17, 2024
@ademidoff ademidoff marked this pull request as ready for review July 18, 2024 07:44
@ademidoff ademidoff requested review from BupycHuk and a team as code owners July 18, 2024 07:44
@ademidoff ademidoff requested review from idoqo and JiriCtvrtka and removed request for a team July 18, 2024 07:44
Base automatically changed from v3-api-breaking-changes to v3 July 18, 2024 08:50
@ademidoff ademidoff requested a review from a team as a code owner July 18, 2024 08:50
api/management/v1/agent.proto Outdated Show resolved Hide resolved
managed/services/management/agent.go Outdated Show resolved Hide resolved
@ademidoff ademidoff force-pushed the PMM-13078-list-available-client-versions branch from d3eb17e to 97efda3 Compare July 18, 2024 09:30
@ademidoff ademidoff force-pushed the PMM-13078-list-available-client-versions branch from cbe0f44 to f295f57 Compare July 18, 2024 11:05
Dockerfile Show resolved Hide resolved
@ademidoff ademidoff requested a review from BupycHuk July 18, 2024 11:17
managed/services/management/agent.go Outdated Show resolved Hide resolved
managed/services/management/agent.go Outdated Show resolved Hide resolved
@ademidoff ademidoff enabled auto-merge (squash) July 29, 2024 06:27
@ademidoff ademidoff merged commit 439e2fc into v3 Jul 29, 2024
29 checks passed
@ademidoff ademidoff deleted the PMM-13078-list-available-client-versions branch July 29, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants