PMM-13078 follow up on PR review comments

percona · Jul 18, 2024 · cbe0f44 · cbe0f44
1 parent 97efda3
commit cbe0f44
Show file tree

Hide file tree

Showing 10 changed files with 134 additions and 117 deletions.
diff --git a/api-tests/management/services/agent_test.go b/api-tests/management/services/agent_test.go
@@ -38,9 +38,9 @@ func TestListAgentVersions(t *testing.T) {
 				Context: ctx,
 			})
 		require.NoError(t, err)
-		require.Len(t, listAgentVersionsOK.Payload.Versions, 1)
+		require.Len(t, listAgentVersionsOK.Payload.AgentVersions, 1)
 
-		expected := pointer.ToString(mgmtSvc.ListAgentVersionsOKBodyVersionsItems0SeverityUPDATESEVERITYUPTODATE)
-		require.Equal(t, expected, listAgentVersionsOK.Payload.Versions[0].Severity)
+		expected := pointer.ToString(mgmtSvc.ListAgentVersionsOKBodyAgentVersionsItems0SeverityUPDATESEVERITYUPTODATE)
+		require.Equal(t, expected, listAgentVersionsOK.Payload.AgentVersions[0].Severity)
 	})
 }
diff --git a/api/management/v1/agent.pb.go b/api/management/v1/agent.pb.go
diff --git a/api/management/v1/agent.pb.validate.go b/api/management/v1/agent.pb.validate.go
diff --git a/api/management/v1/agent.proto b/api/management/v1/agent.proto
@@ -149,12 +149,14 @@ message ListAgentsResponse {
 
 enum UpdateSeverity {
   UPDATE_SEVERITY_UNSPECIFIED = 0;
+  // The client version is newer than the server version.
+  UPDATE_SEVERITY_UNSUPPORTED = 1;
   // The client version matches the server version.
-  UPDATE_SEVERITY_UP_TO_DATE = 1;
-  // The client's minor or patch version is outdated.
-  UPDATE_SEVERITY_REQUIRED = 2;
-  // The client's major version is outdated.
-  UPDATE_SEVERITY_CRITICAL = 3;
+  UPDATE_SEVERITY_UP_TO_DATE = 2;
+  // The client's minor or patch version is older.
+  UPDATE_SEVERITY_REQUIRED = 3;
+  // The client's major version is older.
+  UPDATE_SEVERITY_CRITICAL = 4;
 }
 
 message AgentVersions {
@@ -172,5 +174,5 @@ message ListAgentVersionsRequest {}
 
 message ListAgentVersionsResponse {
   // List of Agent versions.
-  repeated AgentVersions versions = 1;
+  repeated AgentVersions agent_versions = 1;
 }