Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13133 Upgrade pg_query_go to v5 #3000

Merged
merged 16 commits into from
Jun 19, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented May 21, 2024

PMM-13133

Bumps google.golang.org/protobuf from 1.32.0 to 1.34.1.

Dependabot compatibility score


This PR necessitated the following:

  • bump up github.com/bufbuild/buf to v1.31.0
  • bump up github.com/pganalyze/pg_query_go to v5.1.0
  • fix the test for pg query parser.

Note: it's not clear whether pg_query_go migration breaks anything. The API tests passed.

Feature build: SUBMODULES-3644

This PR will close #2995 and #2985.

One other similar PR which is targeting v3 - #2965 - will need to be updated once we merge this one.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.34%. Comparing base (04465d6) to head (bf09b5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
- Coverage   43.38%   43.34%   -0.04%     
==========================================
  Files         399      399              
  Lines       41604    41604              
==========================================
- Hits        18049    18035      -14     
- Misses      21540    21553      +13     
- Partials     2015     2016       +1     
Flag Coverage Δ
admin 11.67% <ø> (ø)
agent 52.69% <ø> (-0.14%) ⬇️
managed 44.47% <ø> (-0.01%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review May 21, 2024 05:39
@ademidoff ademidoff requested review from a team, BupycHuk and JiriCtvrtka as code owners May 21, 2024 05:39
@ademidoff ademidoff requested review from idoqo and removed request for a team May 21, 2024 05:39
@ademidoff ademidoff changed the title Bump google.golang.org/protobuf from 1.32.0 to 1.34.1 in /tools PMM-13133 Upgrade pg_query_go to v5 May 22, 2024
ademidoff added a commit to Percona-Lab/pmm-submodules that referenced this pull request Jun 17, 2024
@ademidoff ademidoff merged commit 6a0ee17 into main Jun 19, 2024
31 checks passed
@ademidoff ademidoff deleted the dependabot-tools-google.golang.org-protobuf-1.34.1 branch June 19, 2024 08:40
@ademidoff ademidoff mentioned this pull request Jun 19, 2024
1 task
ademidoff added a commit that referenced this pull request Jun 20, 2024
* Bump google.golang.org/protobuf from 1.32.0 to 1.34.1 in /tools

Bumps google.golang.org/protobuf from 1.32.0 to 1.34.1.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: upgrade google.golang.org/protobuf in the root as well

* chore: upgrade github.com/bufbuild/buf to the latest

* chore: upgrade github.com/pganalyze/pg_query_go to the latest

* fix: postgresql query test

* fix: pgstatstatements test

* Merge branch 'main' into dependabot-tools-google.golang.org-protobuf-1.34.1

* Merge branch 'main' into dependabot-tools-google.golang.org-protobuf-1.34.1

* Merge branch 'main' into dependabot-tools-google.golang.org-protobuf-1.34.1

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ademidoff added a commit that referenced this pull request Jun 20, 2024
* Bump google.golang.org/protobuf from 1.32.0 to 1.34.1 in /tools

Bumps google.golang.org/protobuf from 1.32.0 to 1.34.1.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: upgrade google.golang.org/protobuf in the root as well

* chore: upgrade github.com/bufbuild/buf to the latest

* chore: upgrade github.com/pganalyze/pg_query_go to the latest

* fix: postgresql query test

* fix: pgstatstatements test

* Merge branch 'main' into dependabot-tools-google.golang.org-protobuf-1.34.1

* Merge branch 'main' into dependabot-tools-google.golang.org-protobuf-1.34.1

* Merge branch 'main' into dependabot-tools-google.golang.org-protobuf-1.34.1

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants