-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-7 Update pg_query_go #2965
base: v3
Are you sure you want to change the base?
PMM-7 Update pg_query_go #2965
Conversation
"error": "error on parsing sql query: subquery in FROM must have an alias" | ||
"tables": [ | ||
"credit_card_wo_complaints", | ||
"without_complaints" | ||
], | ||
"error": "" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query by itself is incorrect but I see no harm in extracting tables from incorrect query
.github/workflows/agent.yml
Outdated
- { mysql: 'mariadb:10.3', mongo: 'percona/percona-server-mongodb:4.4', postgres: 'postgres:9.5', pmm_server: 'perconalab/pmm-server:dev-latest' } | ||
- { mysql: 'mariadb:10.4', postgres: 'postgres:9.6', pmm_server: 'perconalab/pmm-server:dev-latest' } | ||
- { mysql: 'mariadb:10.2', mongo: 'mongo:4.4', postgres: 'postgres:10', pmm_server: 'perconalab/pmm-server:dev-latest' } | ||
- { mysql: 'mariadb:10.3', mongo: 'percona/percona-server-mongodb:4.4', postgres: 'postgres:11', pmm_server: 'perconalab/pmm-server:dev-latest' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why we dropped the minor versions though (e.g testing on 10.x)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2965 +/- ##
=====================================
Coverage ? 44.57%
=====================================
Files ? 358
Lines ? 35214
Branches ? 0
=====================================
Hits ? 15697
Misses ? 17902
Partials ? 1615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BupycHuk |
8421bc2
to
da25a0c
Compare
4b06c24
to
6a7efaf
Compare
PMM-7
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: