Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12448 Fix bug in backup preconditions check function #2437

Merged
merged 6 commits into from
Sep 13, 2023
Merged

PMM-12448 Fix bug in backup preconditions check function #2437

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e85edd
PMM-12448 Fix bug
artemgavrilov Aug 25, 2023
dfd788a
Merge branch 'main' into PMM-12448-backup-preconditions-bugfix
artemgavrilov Aug 29, 2023
8429fae
Merge branch 'main' into PMM-12448-backup-preconditions-bugfix
artemgavrilov Sep 5, 2023
36c5b04
Merge branch 'main' into PMM-12448-backup-preconditions-bugfix
artemgavrilov Sep 12, 2023
abb0e1c
Merge branch 'main' into PMM-12448-backup-preconditions-bugfix
artemgavrilov Sep 13, 2023
84481be
Merge branch 'main' into PMM-12448-backup-preconditions-bugfix
artemgavrilov Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion managed/services/preconditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ func CheckArtifactOverlapping(q *reform.Querier, serviceID, locationID, folder s
}

for _, artifact := range artifacts {
if artifact.ServiceID != serviceID {
// We skip artifacts made on services that are no longer exists in PMM. However, in future we can improve this function
// by storing required information right in artifact model.
if artifact.ServiceID != "" && artifact.ServiceID != serviceID {
svc, err := models.FindServiceByID(q, artifact.ServiceID)
if err != nil {
return err
Expand Down
Loading