Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12448 Fix bug in backup preconditions check function #2437

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Aug 25, 2023

PMM-12448

Link to the Feature Build: SUBMODULES-3371

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2437 (abb0e1c) into main (df3b1aa) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head abb0e1c differs from pull request most recent head 84481be. Consider uploading reports for the commit 84481be to get more accurate results

@@            Coverage Diff             @@
##             main    #2437      +/-   ##
==========================================
- Coverage   42.83%   42.71%   -0.13%     
==========================================
  Files         384      384              
  Lines       48233    48196      -37     
==========================================
- Hits        20663    20585      -78     
- Misses      25626    25674      +48     
+ Partials     1944     1937       -7     
Flag Coverage Δ
managed 43.74% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
managed/services/preconditions.go 76.63% <100.00%> (+0.44%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@artemgavrilov artemgavrilov marked this pull request as ready for review August 25, 2023 10:07
@artemgavrilov artemgavrilov requested a review from a team as a code owner August 25, 2023 10:07
@artemgavrilov artemgavrilov requested review from idoqo, JiriCtvrtka, ademidoff and BupycHuk and removed request for a team August 25, 2023 10:07
@artemgavrilov artemgavrilov enabled auto-merge (squash) September 13, 2023 11:42
@artemgavrilov artemgavrilov merged commit d6be5fd into main Sep 13, 2023
7 checks passed
@artemgavrilov artemgavrilov deleted the PMM-12448-backup-preconditions-bugfix branch September 13, 2023 12:22
ademidoff pushed a commit that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants