PMM-13141 Added feature compatibility version collector #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfsalguero
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
…salguero/mongodb_exporter into PMM-13141_featureCompatibilityVersion
BupycHuk
reviewed
Jun 24, 2024
exporter/exporter.go
Outdated
| @@ -70,6 +70,9 @@ type Opts struct { | |||
| EnableCollStats bool | |||
| EnableProfile bool | |||
| EnableShards bool | |||
| EnableFCV bool // Feature Compatibility Version. | |||
|
|
|||
| FCVInterval time.Duration | |||
There was a problem hiding this comment.
I'm not sure if we need separate interval for FCV.
There was a problem hiding this comment.
this value changes only after upgrades so it should have a big interval to avoid unnecessary reads
There was a problem hiding this comment.
that's true, but it's not a good practice in exporter development. Is this operation generate a big load on system?
There was a problem hiding this comment.
no, not really. We can use one of the default collection intervals
|
|
||
| rawValue := walkTo(m, []string{"featureCompatibilityVersion", "version"}) | ||
| if rawValue != nil { | ||
| version, err := strconv.ParseFloat(fmt.Sprintf("%v", rawValue), 64) |
There was a problem hiding this comment.
wouldn't it better to use hashicorps version library to parse it?
…sion # Conflicts: # go.sum
1 task
BupycHuk
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13141(https://jira.percona.com/browse/PMM-13141
Added a new collector for Feature compatibility version,