PMM-13141 enable fcv collector #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
==========================================
- Coverage 43.40% 43.31% -0.10%
==========================================
Files 399 399
Lines 41692 41553 -139
==========================================
- Hits 18097 17998 -99
+ Misses 21580 21543 -37
+ Partials 2015 2012 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
changed the base branch from
main
to
PMM-12848-enable-currentopmetrics
BupycHuk
changed the base branch from
PMM-12848-enable-currentopmetrics
to
main
BupycHuk
changed the title
JiriCtvrtka
reviewed
Aug 12, 2024
managed/services/agents/mongodb.go
Outdated
| if !ok { | ||
| continue | ||
| if exporter.MongoDBOptions != nil { | ||
| collstatsLimit := int32(200) |
There was a problem hiding this comment.
Maybe it is better to set collstatsLimit as const
JiriCtvrtka
approved these changes
Aug 12, 2024
idoqo
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13141
Link to the Feature Build: SUBMODULES-3686
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: