Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-7 fix tests and a small improvement. #720

Merged
merged 4 commits into from
Oct 9, 2023
Merged

PMM-7 fix tests and a small improvement. #720

merged 4 commits into from
Oct 9, 2023

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Oct 6, 2023

PMM-7 (optional, if ticket reported)

  • Links to other linked pull requests (optional).
  • Tests passed.
  • Fix conflicts with target branch.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@BupycHuk BupycHuk requested a review from a team as a code owner October 6, 2023 18:47
@BupycHuk BupycHuk requested review from ademidoff and JiriCtvrtka and removed request for a team October 6, 2023 18:47
@BupycHuk BupycHuk marked this pull request as draft October 6, 2023 18:48
@BupycHuk BupycHuk marked this pull request as ready for review October 6, 2023 20:32
@BupycHuk BupycHuk enabled auto-merge (squash) October 6, 2023 20:38
@BupycHuk BupycHuk disabled auto-merge October 6, 2023 20:38
@BupycHuk BupycHuk enabled auto-merge (squash) October 6, 2023 20:38
@BupycHuk BupycHuk mentioned this pull request Oct 8, 2023
Merged
2 tasks
ademidoff
ademidoff approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ademidoff ademidoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@BupycHuk BupycHuk merged commit ccd4642 into main Oct 9, 2023
9 checks passed
@BupycHuk BupycHuk deleted the PMM-7-fix-tests branch October 9, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriCtvrtka JiriCtvrtka JiriCtvrtka approved these changes

@ademidoff ademidoff ademidoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BupycHuk @ademidoff @JiriCtvrtka