-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi target support #653
Multi target support #653
Conversation
percona#639) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.47.3 to 1.52.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.47.3...v1.52.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
percona#665) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.52.2 to 1.53.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.52.2...v1.53.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove prometheus/client_golang replace * Apply formater * Downgrade client_golang to previous version * Upgrade exporter-toolkit to v0.10.0
@JiriCtvrtka Hi! Seems like there are problems with the test-cluster. I've checked all tests on my local machine and they are failing like this only if test-cluster didn't set up properly.
means that node mongo-1-1 is down. |
@adnull Hi. Yes I am on it. I also noticed some minor problems in exporter (not in your PR). I will merge this once since it will be fixed. Thank you for your PR and efford. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments.
Once PR with test fixes is merged we will check that tests are not failed and merge this PR. As far as I see there are no backward incompatible changes.
Co-authored-by: Nurlan Moldomurov <[email protected]>
@adnull please fix the linter |
Sure, forgot to format. done. |
@adnull, linters are still complaining. Please address them. |
Sure, i am looking into it and can't get why they fail with the errors like tagalign and nlreturn on the code which is no different from the main code while the same actions in my own repository finish successfully. |
@adnull Seems like your changes wasn't related to linter complains. They existed before, but because you changed those lines linter started complaining. So I merged as is. |
Oh, they almost broke my mind :) Seems like linters list should be adjusted... |
Splitting mongodb_uri with commas and within a double quote for example: "mongodb:connection_string" is no longer acceptable. Is there a way to make the config file backwards compatible as it is for versions 0.0.4 to 3.0.1? Current target is a single cluster multi port as defined by Atlas to monitor and has been working for the last year ENCLOSED in double quotes and has comma separated the 3 target cluster ports as the teams use to connect to the atlas and has been working, but no longer works with version 3.1.0. Here is an example that used to work: mongodb_uri: "mongodb://user:[email protected]:20000,nameN.mongodb.net:20001,nameN.mongodb.net:20002/dbname-qa?authSource=admin&replicaSet=name&ssl=true&retryWrites=true&w=majority" |
I've got the idea and will take a look shortly |
Thanks so much!
…On Tue, Jan 16, 2024 at 3:57 PM Alex ***@***.***> wrote:
Splitting mongodb_uri with commas and within a double quote for example:
"mongodb:connection_string" is no longer acceptable. Is there a way to make
the config file backwards compatible as it is for versions 0.0.4 to 3.0.1?
I've got the idea and will take a look shortly
—
Reply to this email directly, view it on GitHub
<#653 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDCKWXIHBRPWE7ZZFAWNINLYO3SULAVCNFSM6AAAAAAXZAPLH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGUYDAOBXGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Shamika Woods
Technical Account Manager
***@***.***
|
@Swoods3 i've created a pull-request (#780) regarding the problem you've described. But while it is being waited to be approved and included to a release you can use manually compiled code from the branch or try using my docker image with this feature included: https://hub.docker.com/r/adnull/mongodb_exporter |
@adnull Thanks so much! |
This is multi-target support implementation of the mongodb_exporter. This version can be used with prometheus to allow scraping multiple hosts metrics by running just single instance of the exporter.
The code contains minimal changes to implement this feature and doesn't conflict with the main branch.
Multiple targets can be specified in the mongodb.uri option as comma separated list of server URIs
Also, a new option was added - mongodb.connect-timeout-ms which sets default server connection timeout.
Usage notes are located in the readme file in my fork https://github.com/adnull/mongodb_exporter_mt