Fix mongodb_up not set when instance is down #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sancretor
requested review from
tshcherban and
JiriCtvrtka
and removed request for
a team
4 tasks
|
Hi, what are the time expectations of approval? without this feature the exporter is currently unfit for reliability monitoring |
|
I am also facing same issue. Let me know if it fixed. |
JiriCtvrtka
requested review from
ademidoff and
BupycHuk
and removed request for
tshcherban and
ritbl
|
@Sancretor Could you resolve conflicts? PR looks good and then we can proceed to merging of it. Thank you. |
|
Hi @Sancretor, sorry for bothering you. We found out that similar changes were merged as part of #653 and we already released it in v0.40.0 . Thank you for the contribution, we are closing this PR as duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a MongoDB instance is down, the exporter does not produce any metrics, while we would expect it to return
mongodb_up 0. This fix is an attempt to fix issues described in #347, #444 and #483.It's my first PR on Go code so any feedback would be useful !
Also, sorry if I missed something on the whole PR process, don't hesitate to tell me 😅
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.