Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch MAILER_SMTP_FROM_EMAIL and MAILER_SMTP_USER defaults and fix CLA signing script #358

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

kevinam99
Copy link
Contributor

Aims to fix issue #356 with the same title

Does this require any tests to be updated?

@kevinam99
Copy link
Contributor Author

kevinam99 commented Dec 18, 2024

Also fixed the issue with the CLA signing script. Was getting this error

base64: invalid option -- w
Usage: base64 [-Ddh] [-b num] [-i in_file] [-o out_file]
-b, --break break encoded string into num character lines
-Dd, --decode decodes input
-h, --help display this message
-i, --input input file (default: "-" for stdin)
-o, --output output file (default: "-" for stdout)

@kevinam99 kevinam99 changed the title Switch MAILER_SMTP_FROM_EMAIL and MAILER_SMTP_USER defaults Switch MAILER_SMTP_FROM_EMAIL and MAILER_SMTP_USER defaults and fix CLA signing script Dec 18, 2024
This is to avoid possible inconsistencies when used with non mac OSs
@wmnnd
Copy link
Contributor

wmnnd commented Dec 18, 2024

Oh, fabulous, thanks for taking this on! I’ll include this in the next release and update the website docs accordingly.

Also thanks for signing the CLA and reporting the issue with the base64 tool. It looks like there is an incompatibility between the macOS version (which you were probably using) and the GNU versions. While the macOS version has the -b parameter, GNU versions have -w But I’ll fix that after merging your PR.

@wmnnd wmnnd merged commit faa4a1f into pentacent:main Dec 18, 2024
2 checks passed
@kevinam99
Copy link
Contributor Author

Yeah, probably a macOS thing so I went ahead and removed the flag altogether. That too seems to achieve the same result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants