Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch MAILER_SMTP_FROM_EMAIL and MAILER_SMTP_USER defaults #356

Closed
wmnnd opened this issue Dec 4, 2024 · 2 comments
Closed

Switch MAILER_SMTP_FROM_EMAIL and MAILER_SMTP_USER defaults #356

wmnnd opened this issue Dec 4, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wmnnd
Copy link
Contributor

wmnnd commented Dec 4, 2024

Currently, only MAILER_SMTP_USER needs to be set. If it's set, MAILER_SMTP_FROM_EMAIL defaults to the value of MAILER_SMTP_USER. This logic should be reversed to avoid issues where the SMTP user is not an email address or considered private.
@wmnnd wmnnd added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2024
@wmnnd wmnnd mentioned this issue Dec 4, 2024
Closed
@kevinam99 kevinam99 mentioned this issue Dec 18, 2024
Merged
@kevinam99
Copy link
Contributor

Hey @wmnnd. I decided to take this up and opened the PR for it here #358

@kevinam99
Copy link
Contributor

Just a nudge to close this issue

@wmnnd wmnnd closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmnnd @kevinam99