Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASE-2049 | Resolve ESLint errors #861

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
077177c
Apply linter fixes
nayeonk Apr 30, 2024
308f1b6
Testing so far
nayeonk May 14, 2024
582b1bb
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
JordanPak May 21, 2024
11b5941
Remove seemingly-outdated @wordpress/no-global-event-listener ignore
JordanPak May 21, 2024
ebe3ab2
Apply lint-fix to a couple files
JordanPak May 21, 2024
e8bf55e
Make prod:js happy with VideoShowcase eslint-wise
JordanPak May 21, 2024
2c9cf64
Address misc eslint issues in prod:js that were preventing builds to …
JordanPak May 21, 2024
e18046a
Update package lock with some jest stuff someone apparently thinks we…
JordanPak May 21, 2024
eb32d6e
Add claryfing comments on eslint config files
nayeonk Jun 4, 2024
06754b8
Disable camelcase for larva eslint rule
nayeonk Jun 4, 2024
6c45b50
Ignore ESLint import/no-extraneous-dependencies (Larva package)
JordanPak Jun 18, 2024
51ca619
Resolve "config is already in outside scope" issue in twig-to-php-parser
JordanPak Jun 18, 2024
67be3f9
Resolve ESLint issues with twig-to-php-parser
JordanPak Jun 18, 2024
096ce6a
Allow console.log for error in twig-to-php-parser/getConfig
JordanPak Jun 18, 2024
cff4c13
Address ESLint issues in css-algo/rule.js
JordanPak Jun 18, 2024
1d954b5
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
JordanPak Jul 16, 2024
4b5f3dc
Address ESLint findings on stylelint-config/.../custom-formatter.js
JordanPak Jul 16, 2024
56f0a8e
Remove duplicate stylelint rules
JordanPak Jul 30, 2024
95739a9
sort stylelint rules alphabetically
JordanPak Jul 30, 2024
a537c4a
Make Prettier happy
JordanPak Jul 30, 2024
a0b84af
Add missing return types
JordanPak Jul 30, 2024
15c4f6b
Add React compatibility to larva package ESLint
JordanPak Jul 30, 2024
334b9fd
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
JordanPak Sep 10, 2024
ea6639e
Swap ReactDOM.render with React client createRoot
JordanPak Sep 10, 2024
9852a2a
Revert "Swap ReactDOM.render with React client createRoot"
JordanPak Sep 10, 2024
3b0614c
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
JordanPak Oct 1, 2024
f2a85e3
Catch up Larva lock versioning to the .1 patch
JordanPak Oct 1, 2024
3a2d370
Remove @babel/preset-react from pmc-larva package lock? (happened aft…
JordanPak Oct 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ jest-setup.js

a-space-children.browser-test.js
browser-test-setup.js

**/__tests__
**/__test__
6 changes: 3 additions & 3 deletions _reports/a-font-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
*
* For each brand, go to https://<brand>.larva.pmcdev.io/project/__tests__/style-guide/
* In the console, type:
let arr = [];
document.querySelectorAll( 'p[class^=a-font]').forEach( node => arr.push( node.classList[0] ) )
console.log( arr )
let arr = [];
document.querySelectorAll( 'p[class^=a-font]').forEach( node => arr.push( node.classList[0] ) )
console.log( arr )
* Copy the object and those are the font names.
* This could be automated in the future.
*
Expand Down
161 changes: 2 additions & 159 deletions build/js/common.js

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions build/js/common.js.LICENSE.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*!
* Flickity v2.3.0
* Touch, responsive, flickable carousels
*
* Licensed GPLv3 for open source use
* or Flickity Commercial License for commercial use
*
* https://flickity.metafizzy.co
* Copyright 2015-2021 Metafizzy
*/

/*!
* Unidragger v2.4.0
* Draggable base class
* MIT license
*/

/*!
* Unipointer v2.4.0
* base class for doing one thing with pointer event
* MIT license
*/

/*!
* getSize v2.0.3
* measure size of elements
* MIT license
*/
31 changes: 1 addition & 30 deletions build/js/larva-ui.js

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion entries/common.entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const spritePath = ( () => {

ajaxIconSprite( spritePath );

// eslint-disable-next-line @wordpress/no-global-event-listener
document.addEventListener( 'DOMContentLoaded', () => {
//document has been completely loaded and parsed
initCollapsible();
Expand Down
1 change: 1 addition & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ module.exports = {
'/larva-patterns/',
],
setupFiles: [ './jest-setup.js' ],
preset: '@wordpress/jest-preset-default',
};
Loading
Loading