Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASE-2049 | Resolve ESLint errors #861

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Conversation

JordanPak
Copy link
Contributor

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-r6lyyrt4v-penske-media-corp.vercel.app

Built with commit 3a2d370.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Oct 1, 2024

🚨 Backstop Visual Regression Tests Failed: View the results for 3a2d37030f590bc47cafe71266fb317f73a3fcda.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants