Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show Nabla Swap tooltips, change column names #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sharqiewicz
Copy link
Collaborator

@Sharqiewicz Sharqiewicz commented Sep 26, 2024

🦈 PR

  • Rename the first column of the swap UI to "Asset"
  • Add a tool tip next to "Pool liabilities" and "Reserves" titles
  • Tool tip message for Pool liabilities - Amount of liquidity provided initially by LPs
  • Tool tip message for Reserves - Amount of tokens in the pool

@Sharqiewicz Sharqiewicz linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 69520b8
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66f53063cba83d0008693fb5
😎 Deploy Preview https://deploy-preview-565--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TorstenStueber
Copy link
Member

Sorry @Sharqiewicz this ticket was not ready for dev and should not have been in the Ready column. There is still ongoing discussion.

@prayagd The definition of Pool liabilities as "Amount of liquidity provided initially by LPs" is wrong (see also my comment here).

Pool liabilities deviate from the "Amount of liquidity provided initially by LPs" further and further due to

  • slippage
  • accumulated fees

Eventually the liability will deviate a lot from the "Amount of liquidity provided initially by LPs".

There is no simple, intuitive way to explain what "liability" means. As I wrote before, it is a number used for internal accounting to determine the current slippage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the first Swap pool UI column and add tool tip
2 participants