-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the first Swap pool UI column and add tool tip #474
Comments
Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz |
A note for the implementation of this. Instead of showing the value of the 'name' field, we should then instead show the 'symbol' field. For the current set of deployed contracts this means that 'Mock BRL' will show as 'BRL'. @prayagd if you want this to say 'BRL.s' instead, we would need to redeploy the contracts on Foucoco yet again. |
Please add your planning poker estimate with Zenhub @TorstenStueber |
@prayagd it is not correct to rename "Pool liabilities" to "Deposits". What even is a deposit? The number of LP tokens in circulation or the number of pool tokens deposited into the pool. The latter is the "reserves". If you intend to express the number of LP tokens in circulation: That isn't the "total liabilities" either, instead it is the "total supply", a different value managed by the pool. Total liabilities and total supply are similar but will deviate further and further over time. |
@TorstenStueber Fair point, should we instead add tooltips to these titles? so the end user understands this term. |
Pool liability is a mathematical term defined in Nabla, it is Nabla specific. Pool liabilities are mostly used to calculate the slippage by comparing the liabilities against the reserves (i.e., the amount of tokens in the pool). We might just not expose this number to the end user and leave it to Nabla as an internal accounting mechanism. |
IIUC @TorstenStueber suggested removing the pool liabilities item from the table. Removing the whole column and not replacing it with anything else. |
Okay but didn't you put the requirement into the ticket that you want to change away from that? The ticket says we should 'Rename the "Pool liabilities" column to "Deposits"'. As @TorstenStueber pointed out, this renaming would make it inaccurate as liabilities don't equate to deposits. So we either leave it the way it is or remove the column. |
You are right, so i suggest we add tooltips to Pool liabilites. So the user knows what it exactly it is. I will change the ticket description. |
@TorstenStueber @ebma does the updated requirement make sense? Or would we still be saying something inaccurate to the user (tooltip)? |
So my reasoning is as follows: even for me it would be hard to understand what these numbers mean, an I defined them in the first place when I specified Nabla. Maybe they make sense for arbitrageurs but I would not even know how they get their knowledge about how these numbers work. The only documentation that comes close to explaining it is our blog post (not even the official Nabla docs go into details). Neither the spec that defines it in all detail nor the source code is publicly available currently. If we want to indicate anything more meaningful why don't we just display the a) coverate ratio and b) the current amount of pool tokens (which is strictly not the "reserve" but the "reserve + slippage")? |
We are working on getting the first version of the docs ready for Forex AMM
Personally don't think we should share CR as it is technical for the end user and would also clutter the table there, but curious to know why do you think this information would be helfpul. |
@prayagd This was just a response to your sentence:
So how does an arbitrageur understand how skewed the pool is if it is not clear what "liability" means? If we really want to indicate the skewness, then the CR is the exact parameter that express this. CR = 100% => balanced: CR < 100% => skewed to one side (incentive to fill the pool), CR > 100% => skewed to the other side (incentive to empty the pool). Anyway, we can also just show the liability and the reserves (without slippage) as you propose. At the end CR = liability/reserve and they could calculate the CR themselves. We need to educate our users either way about what liability or what CR means. |
@TorstenStueber could you suggest a short but more accurate description of both Liabilities and Reserves in the context of Nabla? Maybe on the lines of @prayagd any reasoning for adding 'Pool' only for liabilities and not for reserves? Since both are pool-related terms, we should either add the word to both or neither. I would go with neither. Also, let's include showing the pool caps / limits as this would be very relevant information for the user. I'd suggest keeping it in the same column as Liabilities (see screenshot) in this way 'Liabilities / Cap' because it's quite closely related to the liabilities i.e. the LP can go up to the cap, whereas the reserves can be lesser or more than both - liabilities and caps. |
There is no simple way to explain what liability. It is an internally used accounting mechanism to determine the current slippage. See my comment here. It is something like provided liquidity plus accumulated fees and partly altered by accumulated slippage. Reserves is the amount of "usable" pool tokens (usable for swap outs). It is less than the actual tokens in the pool (the pool balance) but the rest of the tokens are not available for swaps. So this is a very meaningful term to the end user. The term liability is probably only useful to the end user to indicate whether the pool is unbalanced to a certain side. Liability < reserve => you will get a reward for swapping into the pool and bringing it back to equilibrium. Liability > reserve => you will get a reward for swapping out of the pool and bringing it back to equilibrium. This can likewise be expressed by showing the coverage ratio. |
Could you try explaining this a bit more? I am trying to asset why the definition - Could my logic be applied to the definition of Reserves ( |
Yes, that's a way to characterize it: if the pool is perfectly balanced (CR = 100%), then the "total liability" is the amount of pool tokens all liquidity providers together are eligible to withdraw (if they all together redeem all their LP tokens). If the pool is not balanced (either CR < 100% or CR > 100%), then this amount is less, i.e., adjusted for slippage. So, to keep it simple: for perfectly balanced pools: "total liability = amount of pool tokens available for withdrawals". But this definition is almost tautologic: "perfectly balanced" means that "total liability = reserve" and I already wrote above that "reserve = usable pool tokens". So in this sense: usable for swaps or usable for liquidity providers to withdraw. |
@TorstenStueber @vadaynujra i think so we are going in circles |
@prayagd can you give a reasoning for the advantage for keeping the notion "liability" instead of, e.g., CR. |
Two reasons
|
I thought that this is the reason. I reached out to them whether they had any particular reasoning behind this. |
@vadaynujra to continue the conversation here. The pool cap is only relevant for deposits. For that reason I would just show it when someone wants to make a swap pool deposit instead of showing it in the table. |
@TorstenStueber In that case the depositor would need to click the Deposit button, and then be told that they cannot because of some limit being reached. On the table it saves them that click and also provides context about how liabilities can only go as high as the cap / limit. Probably why the Nabla team also did it like that. I also checked Hydration which is another single sided liq DEX (and so also has limits on pools), and they also show it one step before the user clicks the button to add liquidity (in screenshot - Add and Join Farms). |
@vadaynujra Liabilities are not limited by the cap. The cap measures is a cap on the pool tokens when doing deposits. Liabilities are a different unit, particularly with accumulated fees. |
I've asked the Nabla team why they did it like this. Let's make a decision after. |
Context
Currently, the few columns of the Swap pool UI are not very clear, this ticket is to update them in a way that it is simpler to understand for the majority of DeFi / AMM users with knowledge of 2-asset pool AMMs.
Requirement
Note
The text was updated successfully, but these errors were encountered: