Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement swap assets button #480

Conversation

Sharqiewicz
Copy link
Collaborator

@Sharqiewicz Sharqiewicz commented May 30, 2024

What:

As a user i should be able to reverse the direction of swap on the Forex AMM swap UI

How:

✅ Implement Swap Assets Button (swaps assets and amount)

Closes: #466

@Sharqiewicz Sharqiewicz linked an issue May 30, 2024 that may be closed by this pull request
@Sharqiewicz Sharqiewicz requested review from ebma and prayagd May 30, 2024 12:47
Copy link

netlify bot commented May 30, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit edbe066
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/665899617df831000851c328
😎 Deploy Preview https://deploy-preview-480--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@vadaynujra
Copy link

Tested the feature. Video link.
Observations:

  • There is now an option to interchange the assets - expected
  • Direction changes (pointing up or down) for each click - expected
  • Amount also changes along with the interchange of assets - expected

Ready to be merged.

@Sharqiewicz Sharqiewicz merged commit af21931 into main May 31, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 466-add-a-arrow-to-reverse-the-swap-on-the-swap-ui-of-forex-amm branch May 31, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a arrow to reverse the swap on the swap UI of forex AMM
3 participants