Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a arrow to reverse the swap on the swap UI of forex AMM #466

Closed
prayagd opened this issue May 28, 2024 · 5 comments · Fixed by #480
Closed

Add a arrow to reverse the swap on the swap UI of forex AMM #466

prayagd opened this issue May 28, 2024 · 5 comments · Fixed by #480
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented May 28, 2024

Context

As a user i should be able to reverse the direction of swap on the Forex AMM swap UI

Requirement

  • Show a arrow icon between the source input field and destination input field
  • Clicking on the arrow icon should reverse the swap i.e source should become destination as vice versa
  • When reversing change both the assets and the amount that are entered

Note

@prayagd
Copy link
Collaborator Author

prayagd commented May 28, 2024

Will add the arrow icon as i get it from Klaus

@prayagd
Copy link
Collaborator Author

prayagd commented May 28, 2024

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz

@prayagd
Copy link
Collaborator Author

prayagd commented May 28, 2024

@prayagd to add a video of the uniswap reference

@TorstenStueber
Copy link
Member

This is already implicitly possible by just selecteding the "To" asset as the "From" asset (or vice versa). In this case the UI will just swap both assets (instead of having equal "To" and "From" assets).

@prayagd
Copy link
Collaborator Author

prayagd commented May 29, 2024

This is already implicitly possible by just selecteding the "To" asset as the "From" asset (or vice versa). In this case the UI will just swap both assets (instead of having equal "To" and "From" assets).

That is not intuitive @TorstenStueber Most people who use dex are used to the arrow funtionality

@Sharqiewicz Sharqiewicz self-assigned this May 29, 2024
@Sharqiewicz Sharqiewicz linked a pull request May 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants