Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show Nabla Swap tooltips, change column names #565

Merged

Conversation

Sharqiewicz
Copy link
Collaborator

@Sharqiewicz Sharqiewicz commented Sep 26, 2024

🦈 PR

  • Rename the first column of the swap UI to "Asset"
  • Add a tool tip next to "Pool liabilities" and "Reserves" titles
  • Tool tip message for Pool liabilities - Amount of liquidity provided initially by LPs
  • Tool tip message for Reserves - Amount of tokens in the pool

@Sharqiewicz Sharqiewicz linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit cbb125a
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/67191747df03c20008c13a5e
😎 Deploy Preview https://deploy-preview-565--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TorstenStueber
Copy link
Member

Sorry @Sharqiewicz this ticket was not ready for dev and should not have been in the Ready column. There is still ongoing discussion.

@prayagd The definition of Pool liabilities as "Amount of liquidity provided initially by LPs" is wrong (see also my comment here).

Pool liabilities deviate from the "Amount of liquidity provided initially by LPs" further and further due to

  • slippage
  • accumulated fees

Eventually the liability will deviate a lot from the "Amount of liquidity provided initially by LPs".

There is no simple, intuitive way to explain what "liability" means. As I wrote before, it is a number used for internal accounting to determine the current slippage.

@vadaynujra
Copy link

vadaynujra commented Oct 1, 2024

@prayagd not sure if you saw my comment here, but shall we keep the column names consistent in adding the word Pool, or not? Let's remove it from both (like Nabla have) as the user is already in the Swap Pools page?

@prayagd
Copy link
Collaborator

prayagd commented Oct 3, 2024

@prayagd not sure if you saw my comment #474 (comment), but shall we keep the column names consistent in adding the word Pool, or not? Let's remove it from both (like Nabla have) as the user is already in the Swap Pools page?

Agree to the suggestion

@Sharqiewicz
Copy link
Collaborator Author

@vadaynujra @prayagd What is the conclusion?

@prayagd
Copy link
Collaborator

prayagd commented Oct 18, 2024

@TorstenStueber Now that we know caps are not relevant for us for this version of Forex AMM, should we discard all the changes above to add tool tips and add one more column to show the CR? was the agreement in the meeting to remove the liabilities too?

@prayagd
Copy link
Collaborator

prayagd commented Oct 18, 2024

@Sharqiewicz I would suggest getting rid of the tool tips and just renaming the first column to "Asset", Suggesting this because the ticket has been going on for a longer time and all further changes can be done in a separate ticket. do you agree @TorstenStueber @ebma ?

@ebma
Copy link
Member

ebma commented Oct 18, 2024

Sure, we can reduce the scope here and follow up in another ticket.

@TorstenStueber
Copy link
Member

Yes, agree. Let's get this ticket done with a reduced scope and let's open another ticket if we consider this necessary. I am currently writing the Forex AMM docs in a way that it should work well with the current table layout.

@prayagd
Copy link
Collaborator

prayagd commented Oct 21, 2024

@Sharqiewicz let's reduce the scope and just rename the first column to "Asset"

@Sharqiewicz
Copy link
Collaborator Author

@prayagd Is it good now?

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

This PR also addresses #592 now so we can close that ticket as well afterwards.

@Sharqiewicz Sharqiewicz merged commit 29c0c3e into main Oct 24, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 474-rename-the-first-swap-pool-ui-column-and-add-tool-tip branch October 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the first Swap pool UI column and add tool tip
5 participants