-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show Nabla Swap tooltips, change column names #565
show Nabla Swap tooltips, change column names #565
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sorry @Sharqiewicz this ticket was not ready for dev and should not have been in the Ready column. There is still ongoing discussion. @prayagd The definition of Pool liabilities as "Amount of liquidity provided initially by LPs" is wrong (see also my comment here). Pool liabilities deviate from the "Amount of liquidity provided initially by LPs" further and further due to
Eventually the liability will deviate a lot from the "Amount of liquidity provided initially by LPs". There is no simple, intuitive way to explain what "liability" means. As I wrote before, it is a number used for internal accounting to determine the current slippage. |
Agree to the suggestion |
@vadaynujra @prayagd What is the conclusion? |
@TorstenStueber Now that we know caps are not relevant for us for this version of Forex AMM, should we discard all the changes above to add tool tips and add one more column to show the CR? was the agreement in the meeting to remove the liabilities too? |
@Sharqiewicz I would suggest getting rid of the tool tips and just renaming the first column to "Asset", Suggesting this because the ticket has been going on for a longer time and all further changes can be done in a separate ticket. do you agree @TorstenStueber @ebma ? |
Sure, we can reduce the scope here and follow up in another ticket. |
Yes, agree. Let's get this ticket done with a reduced scope and let's open another ticket if we consider this necessary. I am currently writing the Forex AMM docs in a way that it should work well with the current table layout. |
@Sharqiewicz let's reduce the scope and just rename the first column to "Asset" |
@prayagd Is it good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR also addresses #592 now so we can close that ticket as well afterwards.
🦈 PR