-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: add TyphosDisplaySwitcher to positioner_row.ui #587
Conversation
pip py3.9 failed once with the standard flood of QMenus, but passed on rerun... :/ |
This is a good call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some oddity here with the (?) button- it doesn't seem to functional when these are subdevices. I'd expect to see e.g. the motor class docstring or the ophyd doc field. Otherwise everything here works as expected.
Actually- it seems like only for the positioner row templates, the ? button is completely non-functional. There must be some code reason for this. |
Ah, so I think the code for the help button is defined only in the full title bar widget, not in this button. So we'd need to do a bit of a refactor to make the help button work as intended. |
Ah you're totally right. The help frame is created and added to TyphosDisplayTitle, which sets up the toggle functionality and webviewer. In the interest of keeping this template compact, maybe we just show the docstring via tooltip and disable clicking for this template. |
Description
Adds TyphosDisplaySwitcher to row positioner widget.
This only required changes to the .ui file, to my complete amazement. 👏
Motivation and Context
closes #580 in this case, but not the general one.
How Has This Been Tested?
Clicking through all the other templates available to me, and I never got stuck
Where Has This Been Documented?
This PR