Merge pull request #587 from tangkong/mnt_ui_switch

MNT: add TyphosDisplaySwitcher to positioner_row.ui
pcdshub · Sep 14, 2023 · 8f68987 · 8f68987
2 parents 8e9dcdf + 30fd859
commit 8f68987
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 3 deletions.
diff --git a/typhos/positioner.py b/typhos/positioner.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import inspect
 import logging
 import os.path
 import threading
@@ -10,6 +11,8 @@
 from pydm.widgets.channel import PyDMChannel
 from qtpy import QtCore, QtWidgets, uic
 
+from typhos.display import TyphosDisplaySwitcher
+
 from . import dynamic_font, utils, widgets
 from .alarm import AlarmLevel, KindLevel, _KindLevel
 from .panel import SignalOrder, TyphosSignalPanel
@@ -828,6 +831,7 @@ class _TyphosPositionerRowUI(_TyphosPositionerUI):
     status_container_widget: QtWidgets.QFrame
     extended_signal_panel: Optional[TyphosSignalPanel]
     error_prefix: QtWidgets.QLabel
+    switcher: TyphosDisplaySwitcher
 
 
 class TyphosPositionerRowWidget(TyphosPositionerWidget):
@@ -964,6 +968,33 @@ def add_device(self, device: ophyd.Device) -> None:
 
         self.ui.device_name_label.setText(device.name)
         self.ui.notes_edit.add_device(device)
+        self.ui.switcher.help_toggle_button.setToolTip(self._get_tooltip())
+        self.ui.switcher.help_toggle_button.setEnabled(False)
+
+    def _get_tooltip(self):
+        """Update the tooltip based on device information."""
+        # Lifted from TyphosHelpFrame
+        tooltip = []
+        # BUG: I'm seeing two devices in `self.devices` for
+        # $ typhos --fake-device 'ophyd.EpicsMotor[{"prefix":"b"}]'
+        for device in sorted(
+            set(self.devices),
+            key=lambda dev: self.devices.index(dev)
+        ):
+            heading = device.name or type(device).__name__
+            tooltip.extend([
+                heading,
+                "-" * len(heading),
+                ""
+            ])
+
+            tooltip.append(
+                inspect.getdoc(device) or
+                inspect.getdoc(type(device)) or
+                "No docstring"
+            )
+            tooltip.append("")
+        return "\n".join(tooltip)
 
     @utils.linked_attribute('error_message_attribute', 'ui.error_label', True)
     def _link_error_message(self, signal, widget):

diff --git a/typhos/ui/widgets/positioner_row.ui b/typhos/ui/widgets/positioner_row.ui
@@ -115,6 +115,19 @@
        </property>
       </widget>
      </item>
+     <item>
+      <widget class="TyphosDisplaySwitcher" name="switcher">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Maximum" vsizetype="Preferred">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="toolTip">
+        <string/>
+       </property>
+      </widget>
+     </item>
     </layout>
    </item>
    <item>
@@ -1258,15 +1271,20 @@ Screen</string>
    <header>typhos.alarm</header>
   </customwidget>
   <customwidget>
-   <class>TyphosNotesEdit</class>
-   <extends>QLineEdit</extends>
-   <header>typhos.notes</header>
+   <class>TyphosDisplaySwitcher</class>
+   <extends>QFrame</extends>
+   <header>typhos.display</header>
   </customwidget>
   <customwidget>
    <class>TyphosRelatedSuiteButton</class>
    <extends>QPushButton</extends>
    <header>typhos.related_display</header>
   </customwidget>
+  <customwidget>
+   <class>TyphosNotesEdit</class>
+   <extends>QLineEdit</extends>
+   <header>typhos.notes</header>
+  </customwidget>
  </customwidgets>
  <resources/>
  <connections/>