Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i_954,955 Fix awards.json compare and results.tsv generation #956

Merged
merged 1 commit into from
May 7, 2024

Conversation

johnbrvc
Copy link
Collaborator

Description of what the PR does

Fix bug in FileComparisionUtilities where the same value was being compared to itself for team ID lists. Create dummy FinalizeData object if contest is not yet finalized.

Issue which the PR addresses

Fixes #954 #955

Environment in which the PR was developed (OS,IDE, Java version, etc.)

Windows 11
jdk1.8.0_351

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

  1. Use the folders in testdata\FileComparisonUtilitiesTest\resultscompwork\results and the awards.json file under domjudge and pc2.
  2. Change the team id list in one of the awards.json files for one or more citations.
  3. Run the Results Compare from an administrator.

Note that the the comparison onawards.jsonnow fails as expected.

On an unfinalized contest, attempt to generate a results.tsv report from an administrator or server.
The file is now generated.

Fix bug in FileComparisionUtilities where the  same value was being compared to itself for team ID lists.
Create dummy FinalizeData object if contest is not yet finalized.
@johnbrvc johnbrvc added this to the 9.11.0 milestone Apr 16, 2024
@johnbrvc johnbrvc self-assigned this Apr 16, 2024
Copy link
Contributor

@troy2914 troy2914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me, and could be considered a one commit change.

Copy link
Collaborator

@kkarakas kkarakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@troy2914
Copy link
Contributor

btw, if this code exists in 9.10.0 I think it should backported there too.

@johnbrvc johnbrvc merged commit 4641d92 into pc2ccs:develop May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results comparison does not correctly compare awards.json
3 participants