i_954,955 Fix awards.json compare and results.tsv generation #956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Fix bug in
FileComparisionUtilities
where the same value was being compared to itself for team ID lists. Create dummyFinalizeData
object if contest is not yet finalized.Issue which the PR addresses
Fixes #954 #955
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Windows 11
jdk1.8.0_351
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
testdata\FileComparisonUtilitiesTest\resultscompwork\results
and theawards.json
file under domjudge and pc2.awards.json
files for one or more citations.Note that the the comparison on
awards.json
now fails as expected.On an unfinalized contest, attempt to generate a
results.tsv
report from an administrator or server.The file is now generated.