Only substring 5, if the string contains "No - ".

src/edu/csus/ecs/pc2/core/util/JSONTool.java

@@ -312,7 +312,9 @@ public ObjectNode convertToJSON(Judgement judgement) {
             solved = true;
             penalty = false;
         } else {
-            name = name.substring(5, name.length());
+            if (name.startsWith("No - ")) {
+                name = name.substring(5, name.length());
+            }
             Properties scoringProperties = model.getContestInformation().getScoringProperties();
             if (judgement.getAcronym().equalsIgnoreCase("ce") || name.toLowerCase().contains("compilation error")
                     || name.toLowerCase().contains("compile error")) {

test/edu/csus/ecs/pc2/core/util/JSONToolTest.java

@@ -0,0 +1,32 @@
+// Copyright (C) 1989-2024 PC2 Development Team: John Clevenger, Douglas Lane, Samir Ashoo, and Troy Boudreau.
+package edu.csus.ecs.pc2.core.util;
+
+import edu.csus.ecs.pc2.core.IInternalController;
+import edu.csus.ecs.pc2.core.model.IInternalContest;
+import edu.csus.ecs.pc2.core.model.Judgement;
+import edu.csus.ecs.pc2.core.model.SampleContest;
+
+/**
+ * Unit test.
+ * 
+ * @author Douglas A. Lane, PC^2 Team, [email protected]
+ */
+public class JSONToolTest extends AbstractTestCase {
+
+    /**
+     * Test judgement not starting with "No - " github issue #950
+     *
+     * @throws Exception
+     */
+    public void testIssue950failed() throws Exception {
+        SampleContest sampleContest = new SampleContest();
+        IInternalContest contest = sampleContest.createContest(2, 2, 12, 12, true);
+        String outputTestDirectory = getOutputDataDirectory();
+        IInternalController controller = sampleContest.createController(contest, outputTestDirectory, true, false); // creates StaticLog instance
+
+        Judgement judgementJE = new Judgement("JE", "JE");
+        contest.addJudgement(judgementJE);
+        JSONTool json_tool = new JSONTool(contest, controller);
+        json_tool.convertToJSON(judgementJE);
+    }
+}

test/edu/csus/ecs/pc2/services/core/JSONToolTest.java

@@ -982,11 +982,11 @@ public void testConvertToJSONJudgement() throws Exception {
         Judgement judgement = contest.getJudgements()[4];
 
         String json = jsonTool.convertToJSON(judgement).toString();
-        //        System.out.println("debug judgement "+json);
+//                System.out.println("debug judgement "+json);
         // debug judgement {"id":"WA2","name":"ave no clue","penalty":true,"solved":false}
 
         assertJSONStringValue(json, "id", "WA2");
-        assertJSONStringValue(json, "name", "ave no clue");
+        assertJSONStringValue(json, "name", "You have no clue"); // does not start with "No - "
         assertJSONBooleanValue(json, "penalty", true);
         assertJSONBooleanValue(json, "solved", false);