Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only substring 5, if the string contains "No - ". #951

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Only substring 5, if the string contains "No - ". #951

merged 2 commits into from
Apr 2, 2024

Conversation

troy2914
Copy link
Contributor

@troy2914 troy2914 commented Apr 1, 2024

fixes #950

See the issue for testing.

@troy2914 troy2914 added the One Approval A very low risk and low LOE PR/Change label Apr 1, 2024
@troy2914
fix junit error in other JSONToolTest
6d7d03d 
and reformat new JSONToolTest.

fixes pc2ccs#950
@troy2914 troy2914 added this to the 9.11.0 milestone Apr 1, 2024
@johnbrvc johnbrvc self-requested a review April 1, 2024 21:49
johnbrvc
johnbrvc approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@johnbrvc johnbrvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code was clearly wrong. The intent was to check if it began in "No - ", and strip that off (for the event feed). This fix addresses that.

@johnbrvc johnbrvc merged commit 7e88e9e into pc2ccs:develop Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbrvc johnbrvc johnbrvc approved these changes

Assignees

@johnbrvc johnbrvc

Labels
One Approval A very low risk and low LOE PR/Change
Projects
None yet
Milestone
9.11.0
2 participants
@troy2914 @johnbrvc