Skip to content

UIKit Fixes & Updates #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 12, 2019
Merged

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Nov 11, 2019

TLDR: a bunch of misc updates cleaning and fixing up the core work from #1078

15237A78-56C4-4476-8CEE-EEEE0E8F8D7F
60721847-8549-4990-A401-8FB6174C491E

This includes:

  • Updated UI for expanding / collapsing in-page code panels + corresponding icon / naming updates used in the Context / Tools menu
  • Added Copy / Copied SVG icons for the copy to clipboard button
  • Reduced the # of initial UI re-renders (particularly unnecessary rerenders of the Nav) via updates to the main HTML template + Layout component
  • Added the Loader UI (spinner) inside Drawer when source code is getting loaded
  • Polished up the UI for the Viewport resizer
  • Added mobile / small screen support for displaying the Nav as a slide out panel (aka vertical nav) + dropdown to allow for the exact same layout options on all screen sizes
    • This also sets us up for a larger Nav UI refactor now that we don’t have totally different Nav behavior on smaller vs larger screen sizes!
  • CSS updates to fix / improve small screen support — in particular, trying to make sure the navigation and viewport content don’t get chopped off!
  • Updated CSS for Pattern Lineage UI to better allow links to wrap if needed
  • Added the ability to auto-close the primary navigation via pressing the escape key + clicking outside the Nav (including slight behavior differences for the mobile panel vs larger screen dropdown / side nav)
  • Ported over the “sticky” copy to clipboard behavior (copy to clipboard button stays at the top of the code snippet, even while scrolling!).
    • Note: Safari for iOS support for this is a bit buggy when scrolling through the code panel due to rendering differences. This will be improved on in a future update!
  • Fixed placeholder text color contrast issues in the global search input
  • Updated the “Open in a New Tab” UI to improve the consistency of updating when expected
  • Updated the Header UI on smaller screens to now display a Close icon when the Nav is open!
  • Updated the Viewport size UI to more reliably display the current viewport size (in particular when initially loading)
  • Started cleaning up the Nav component’s internal logic + updated to no longer auto-close the mobile navigation section you are currently on, in addition to no longer “forgetting” which section you are on while toggling between the vertical and horizontal layout modes on larger screens
  • Theoretically added / restored support for setting the default theme color / layout mode via the Pattern Lab config (need to further test to verify)

Note: this PR includes the same open / close panel fixes from #1074

Closes # (TBD)

@sghoweri
Copy link
Contributor Author

@bmuenzenmeyer any idea why Travis / Netlify didn't run on this PR?

Maybe it has something to do with my PR pointing to another feature branch vs dev? 🤔

@sghoweri sghoweri changed the base branch from feature/uikit-refactor-and-enhancements to dev November 12, 2019 02:38
@sghoweri
Copy link
Contributor Author

Side note: I still want to get these updates merged down into the feature/uikit-refactor-and-enhancements branch vs dev (unless the other updates have already gotten merged down) — I just switched bases to make sure the Travis CI build is running!

@bmuenzenmeyer
Copy link
Member

@sghoweri merged #1078 into dev and merged dev into this PR - good for review I take it?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.144% when pulling 1b89f55 on feature/uikit-refactor-and-enhancements--v2 into 4b2faff on dev.

@sghoweri
Copy link
Contributor Author

@sghoweri merged #1078 into dev and merged dev into this PR - good for review I take it?

Yessir! Thanks @bmuenzenmeyer!

@bmuenzenmeyer
Copy link
Member

netlify is fixed - was a problem with uikit-polyfill not being published

@bmuenzenmeyer bmuenzenmeyer merged commit f41d8bf into dev Nov 12, 2019
@bmuenzenmeyer bmuenzenmeyer deleted the feature/uikit-refactor-and-enhancements--v2 branch November 12, 2019 15:52
@sghoweri sghoweri mentioned this pull request Nov 13, 2019
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…factor-and-enhancements--v2

UIKit Fixes & Updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants