-
Notifications
You must be signed in to change notification settings - Fork 405
Follow-up UIKit Fixes #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up UIKit Fixes #1097
Conversation
One thing I know I’ll need to add to this PR: need to fix the Nav highlighting for level two links that don’t have any nested children. |
…the Nav; improve dropdown open / close animation
…rawer content collapsing on smaller screens + better handling of Nav link cleanup when changing pages
@sghoweri Thanks for this! Only sorta related, but I could use some help getting the local environment set up to make some tweaks to the uikit code in a separate branch. How would I go about getting that set up? I can probably tackle that tonight or tomorrow night. |
Thanks @bradfrost! (PS. you can check out the latest and greatest here if you're curious: https://deploy-preview-1097--patternlab-handlebars-preview.netlify.com/?p=all) |
RE getting a local environment setup, I can do a quick writeup later today (sometime after lunch) to help get you going! |
@bradfrost try giving this a shot -- lemme know if this works and/or if you run into any issues! |
Working on Pattern Lab’s UIKit LocallyStep 1Pull in the latest updates from the
Step 2:Create a temp config file that points to the local Handlebars demo so we can easily preview changes as they’re being made:
NOTE: make sure to not commit this — this is just an example config to help get you going! Step 3: Initially Compile The Handlebars Demo To Have Some Demo Content When Making ChangesIn one terminal / iTerm2 tab, run the following to get the handlebars demo installed and running locally
Step 4: Boot Up a Local Dev Server / Watch for ChangesFinally let’s get the UIKit watch task running + boot up a local dev server to reload when we save any Sass / JS changes In one terminal tab, run the following to boot up a local browser sync server:
And then in a 2nd terminal tab, run the following to start up the UIKit watch task:
|
Awesome thanks so much @sghoweri! I'm able to work through all these steps, but things seem to be falling down on me when I run the And turns it into this: I'm able to get the desired view back by re-running Any suggestions? |
Dang it. Well, the good news is that I actually ran into the same issue yesterday when testing this new workflow out (albeit, I swear this new workflow was working before sending this over... 🤦♂️). Hang tight @bradfrost - troubleshooting this morning! |
PS. If you haven’t guessed it, this is a bit of a different setup than the one I’ve been recently using to work on PL’s UI. Normally all I’ll have to do is just fire up an existing project like Bolt and run the UIKit watch command... 🤔 |
Follow-up UIKit Fixes
Minor UIKIt fixes I had actually originally thought were part of #1094 but mistakenly overlooked (sorry @bmuenzenmeyer!)
These updates include things like: