Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release workflow to use ruby v3.1 #118

Merged
merged 2 commits into from
Dec 10, 2024
Merged

ci: update release workflow to use ruby v3.1 #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2d174
ci: update release workflow to use ruby v3.1
ctran88 Dec 10, 2024
003787b
Merge branch 'main' into PSG-5529-update-ruby-version-for-release
ctran88 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true
ruby-version: '3.0'
ruby-version: '3.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this benefit us for the minor release? For the major I was going to update all Ruby versions to the latest in the CI, dev container and project. Then update the dependancies that are blocked by the lower Ruby version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is required for us to use activesupport. The PR workflows pass because they are set to 3.1, but with the pre-release testing it failed on 3.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

if: ${{ steps.release.outputs.release_created }}
- uses: rubygems/release-gem@v1
if: ${{ steps.release.outputs.release_created }}
Expand Down
Loading