Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release workflow to use ruby v3.1 #118

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 10, 2024

What's New?

This should match the version dependency in the PR workflow and what is required to use ActiveSupport

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 requested a review from a team December 10, 2024 01:26
@@ -24,7 +24,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true
ruby-version: '3.0'
ruby-version: '3.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this benefit us for the minor release? For the major I was going to update all Ruby versions to the latest in the CI, dev container and project. Then update the dependancies that are blocked by the lower Ruby version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is required for us to use activesupport. The PR workflows pass because they are set to 3.1, but with the pre-release testing it failed on 3.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@ctran88 ctran88 merged commit a35d7a4 into main Dec 10, 2024
6 checks passed
@ctran88 ctran88 deleted the PSG-5529-update-ruby-version-for-release branch December 10, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants