-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: op-reth #4377
feat: op-reth #4377
Conversation
Codecov Report
... and 390 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix the base fee params for base mainnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving first round of comments
perf(executor): pre-parse address constants
Historical RPC Daisy Chaining is a feature that should be tackled once this lands since it's not critical. I went ahead and opened up an issue #5300. Further, not supporting historical (pre-bedrock) rpc daisy chaining doesn't prevent a mainnet bedrock node from syncing and following tip successfully. |
feat: Split binaries
@refcell Yes, have you tested or are you testing it now? Due to the receipt RPC fixed for reth #5084 I think it is now possible to sync from op-node at the faster speed |
…tiation fix(rpc): Move reqwest client into EthApiInner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine now,
needs followups for things discussed separately.
would appreciate if @DaniPopes could take a look at the CI changes before we send it
Co-authored-by: refcell.eth <[email protected]>
Co-authored-by: refcell.eth <[email protected]>
chore: PR comments & nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Co-authored-by: Roberto Bayardo <[email protected]> Co-authored-by: refcell.eth <[email protected]> Co-authored-by: Roman Krasiuk <[email protected]> Co-authored-by: refcell <[email protected]> Co-authored-by: nicolas <[email protected]>
Overview
This PR contains the full diff for
op-reth
.Note: 29,725 lines of this diff consists of large genesis files for base goerli and base mainnet.
Resources
op-geth
diffforkdiff
page hosted at op-reth.anton.systems based on op-reth-diff.All Future Issues (tracking)
op-geth mappings
The below toggles contain mappings of all
op-geth
diff changes to their respective places inop-reth
.(if you have questions on this stuff ask @refcell - wrote all these toggles out)
✅
op-geth
Diff Mapping: Core Modifications+901
|-52
+494
|-16
+191
|-0
+96
|-0
+81
|-0
+14
|-0
+83
|-0
+80
|-0
+1
|-0
+1
|-0
+1
|-0
+103
|-5
+5
|-1
+83
|-0
+14
|-3
+1
|-1
+110
|-9
+110
|-9
+4
|-2
+4
|-2
+3
|-0
+3
|-0
+118
|-1
+80
|-0
+12
-1
(this will be accounted for in the revm cost function)+26
|-0
+3
|-0
+3
|-0
(not included since we don't have clique consensus)+58
|-4
+12
|-1
+28
|-2
+18
|-1
+105
|-12
+22
|-2
+4
|-3
+8
|-0
+71
|-7
+123
|-19
+93
|-12
+9
|-0
+21
|-7
✅
op-geth
Diff Mapping: Node modifications+158
|-10
+124
|-8
+95
|-3
+72
|-3
+9
|-0
+1
|-0
+13
|-0
+29
|-5
+1
|-0
+27
|-4
+1
|-1
+10
|-0
+10
|-0
+24
|-2
+7
|-1
+17
|-1
✅
op-geth
Diff Mapping: User API enhancements+995
|-63
+223
|-6
+195
|-6
+28
|-0
+89
|-8
+35
|-6
+52
|-2
+2
|-0
+1
|-1
+1
|-1
+235
|-14
+225
|-14
+10
|-0
+59
|-12
OUT OF SCOPE+59
|-12
+37
|-4
OUT OF SCOPE+1
|-1
+9
|-1
+2
|-2
+25
|-0
+351
|-18
OUT OF SCOPE+3
|-1
+152
|-7
+196
|-10
✅
op-geth
Diff Mapping: Geth extras (not mapped 1:1 since we will have "reth extras")+325
|-25
+90
|-19
+90
|-19
+235
|-6
+103
|-0
+132
|-6
✅
op-geth
Diff Mapping: Other changes+690
|-16
+2
|-2
+4
|-0
+8
|-0
+3
|-0
+3
|-1
+12
|-5
+41
|-1
+281
|-1
+30
|-0
+1
|-0
+7
|-1
+23
|-1
( Part of Priority fee suggestion)+110
|-0
( Part of Priority fee suggestion)+142
|-0
( Part of Priority fee suggestion)+1
|-1
+1
|-1
+19
|-0
+1
|-1
+1
|-1