-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(payload): Ethereum Payload Builder Zero Type #5313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
changed the title
fix(payload): Ethereum Payload Builder
fix(payload): Ethereum Payload Builder [RFC]
Nov 5, 2023
mattsse
requested changes
Nov 5, 2023
mattsse
reviewed
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default usage also needs to be updated:
reth/crates/payload/basic/src/lib.rs
Line 67 in 3d076b1
pub struct BasicPayloadJobGenerator<Client, Pool, Tasks, Builder = ()> { |
refcell
changed the title
fix(payload): Ethereum Payload Builder [RFC]
fix(payload): Ethereum Payload Builder
Nov 5, 2023
refcell
changed the title
fix(payload): Ethereum Payload Builder
fix(payload): Ethereum Payload Builder Zero Type
Nov 5, 2023
mattsse
approved these changes
Nov 6, 2023
mattsse
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines an
EthereumPayloadBuilder
type as the empty tuple type following @gakonst's comment in #4377 (comment)