Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payload): Ethereum Payload Builder Zero Type #5313

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Nov 5, 2023

Description

Defines an EthereumPayloadBuilder type as the empty tuple type following @gakonst's comment in #4377 (comment)

@refcell refcell changed the title fix(payload): Ethereum Payload Builder fix(payload): Ethereum Payload Builder [RFC] Nov 5, 2023
crates/payload/basic/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default usage also needs to be updated:

pub struct BasicPayloadJobGenerator<Client, Pool, Tasks, Builder = ()> {

crates/payload/basic/src/lib.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from mattsse November 5, 2023 19:34
@refcell refcell changed the title fix(payload): Ethereum Payload Builder [RFC] fix(payload): Ethereum Payload Builder Nov 5, 2023
@refcell refcell changed the title fix(payload): Ethereum Payload Builder fix(payload): Ethereum Payload Builder Zero Type Nov 5, 2023
@mattsse mattsse added the A-block-building Related to block building label Nov 6, 2023
@mattsse mattsse added this pull request to the merge queue Nov 6, 2023
Merged via the queue into paradigmxyz:main with commit 22dfe96 Nov 6, 2023
25 checks passed
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants