-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: op-reth #4377
feat: op-reth #4377
Changes from all commits
60b83b9
87909d4
a053c26
a01b9c9
54957c4
3798be1
a84ea91
6470379
6b110d9
4a12a3a
5e046df
ce6731a
a182909
f17dc3c
7edf44d
5b3b524
3321955
738d7da
4dfb9fa
6966735
f2e6bd0
08ed3d3
afb8172
ee59168
19d082d
06e503d
8924c5e
c21a224
7a4536a
d311c2e
2d70e0b
973cc9a
5b4bd07
455d637
bf9901d
e7a6771
9122353
5d7ea82
68b621a
4c00711
b8fd4dd
2a89bcd
d7dd0e2
fc8ebf9
a8978e2
03395dc
3bc22fa
ada47ff
c23408f
394dc00
a956013
8fbba1e
c14c339
122be97
09ff7e4
1decac7
588be43
0619eb9
12c8750
8c546b1
dc9ee70
32c9046
43309e1
c2ea10f
e173828
504273d
95abdc8
dc97883
0977eb7
9cc55d5
a778a50
4e7cdfb
0f2ea91
d4b0fcf
3ce4b83
53b1a18
10b5881
89eba28
982a16f
308c2c0
841accd
6c7882c
d562387
ba309ec
66e9ba0
71836cd
784860c
0b45fb9
7ab8e06
5483c3b
365f784
5aa493f
3f159c5
0a2d948
d3a7871
d1d24a4
4f1b00f
44dee3e
ad8fb13
766076e
2467bc1
d8b575f
9572071
150b9ff
9bb9ade
1a1a57f
a374ea0
47dd6ac
a78518a
ed6fd6a
6dc2aa4
050fb91
07264fe
bc17092
0cd95a9
9275965
3209735
f6b47a1
af8281d
54a1cdc
e7757ff
6fca9cf
ef538f5
f2e1e35
4d4d15f
56aab40
6abad49
91d710e
d044bc7
8f9a748
474b4f4
ce2b28d
75eb78b
0b079b7
f9344e0
055725f
88f4533
53b543c
1559f96
748f1ea
92421ae
4b85a98
d5810ed
d6f7edf
56460a5
d10dcb7
699bed3
0a449d2
d40e986
db68a1a
c0c7346
e19b137
2aa54bc
568eec9
1e771b5
333103f
c645b28
f542a75
39a8997
bef336e
21f551e
c0b7d34
227e472
c84dea0
5d0d294
1a9662d
589b724
ce627e2
6762c34
232f73d
c75b816
aad68f7
4e40abd
e5ee08c
3a0317c
825cc73
c11ec55
aaccff5
a150662
2914165
6051516
00b8c4b
81128ad
b3c4867
6f8139a
b752b9e
e9f1263
28ede82
f5bf065
ea5ab50
497b96e
773d566
0985ed8
04cb5fc
53cf13f
8bab946
f747108
9875971
a776ce8
9139475
e28f740
f740f34
da3a9c5
07b23f6
d082ae3
d3986a6
96548c6
c1c09a1
89a5c53
13d3b14
bb585fb
ef487c0
779ca19
6de2577
23e9440
3190b1f
63cd43d
9c7ab40
0474763
ac050a2
018789f
9be3212
7e87683
45017e6
1e68098
ac96757
fe52763
eeb2c97
3652bca
8cab07b
9423c95
3f9b4e9
b53ed2c
93d5c20
8492578
cd0efc2
af6d37b
05ca268
db54081
619ce45
7482db8
ec97477
32324c9
b2768d0
53e8fc3
6215e45
1d6febf
d261c71
1c4acfd
62f8111
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,18 @@ pub struct PayloadBuilderArgs { | |
/// Maximum number of tasks to spawn for building a payload. | ||
#[arg(long = "builder.max-tasks", help_heading = "Builder", default_value = "3", value_parser = RangedU64ValueParser::<usize>::new().range(1..))] | ||
pub max_payload_tasks: usize, | ||
|
||
/// By default the pending block equals the latest block | ||
/// to save resources and not leak txs from the tx-pool, | ||
/// this flag enables computing of the pending block | ||
/// from the tx-pool instead. | ||
clabby marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// | ||
/// If `compute_pending_block` is not enabled, the payload builder | ||
/// will use the payload attributes from the latest block. Note | ||
/// that this flag is not yet functional. | ||
#[cfg(feature = "optimism")] | ||
#[arg(long = "rollup.compute-pending-block")] | ||
pub compute_pending_block: bool, | ||
Comment on lines
+45
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wdym "not yet functional"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As in, not yet implemented. For context - the In practice, the |
||
} | ||
|
||
impl PayloadBuilderConfig for PayloadBuilderArgs { | ||
|
@@ -58,6 +70,11 @@ impl PayloadBuilderConfig for PayloadBuilderArgs { | |
fn max_payload_tasks(&self) -> usize { | ||
self.max_payload_tasks | ||
} | ||
|
||
#[cfg(feature = "optimism")] | ||
fn compute_pending_block(&self) -> bool { | ||
self.compute_pending_block | ||
} | ||
} | ||
|
||
#[derive(Clone, Debug, Default)] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
//! clap [Args](clap::Args) for op-reth rollup configuration | ||
|
||
/// Parameters for rollup configuration | ||
#[derive(Debug, clap::Args)] | ||
#[command(next_help_heading = "Rollup")] | ||
pub struct RollupArgs { | ||
/// HTTP endpoint for the sequencer mempool | ||
#[arg(long = "rollup.sequencer-http", value_name = "HTTP_URL")] | ||
pub sequencer_http: Option<String>, | ||
|
||
/// Disable transaction pool gossip | ||
#[arg(long = "rollup.disable-tx-pool-gossip")] | ||
pub disable_txpool_gossip: bool, | ||
|
||
/// Enable walkback to genesis on startup. This is useful for re-validating the existing DB | ||
/// prior to beginning normal syncing. | ||
#[arg(long = "rollup.enable-genesis-walkback")] | ||
pub enable_genesis_walkback: bool, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this?
what is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a no-op feature, specifically for the CI matrix. We added the
ethereum
feature as a switch for CI with and withoutoptimism
enabled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense imo
let's add s one line note