fix(cli) Allow Pruning CLI Args to take precedence over TOML configuration #10774
+89
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garwahl
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
|
Hey @emhane would love your review on this one too when you get the chance. |
emhane
approved these changes
Sep 9, 2024
|
ping @mattsse PTAL nits resolved |
|
ping @mattsse PTAL |
|
Hey @mattsse LMKWYT changes have been addressed |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #10639 is in, we expose all
PruneConfigvia CLI. Now that configuration can be set either via CLI orreth.tomlwe should allow CLI to clobber and take precedence over any file based configuration.This PR then addresses discussion in #9808, superseding the approach in #10409