prune_config no longer returns an optional value

[mattsse]

Describe the feature

in #10639 additional prune cli args were introduced and the return value of

reth/crates/node/core/src/args/pruning.rs

Lines 94 to 145 in cb0625c

	/// Returns pruning configuration.
	pub fn prune_config(&self, chain_spec: &ChainSpec) -> Option<PruneConfig> {
	// Initialise with a default prune configuration.
	let mut config = PruneConfig::default();
	// If --full is set, use full node defaults.
	if self.full {
	config = PruneConfig {
	block_interval: 5,
	segments: PruneModes {
	sender_recovery: Some(PruneMode::Full),
	transaction_lookup: None,
	// prune all receipts if chain doesn't have deposit contract specified in chain
	// spec
	receipts: chain_spec
	.deposit_contract
	.as_ref()
	.map(|contract| PruneMode::Before(contract.block))
	.or(Some(PruneMode::Distance(MINIMUM_PRUNING_DISTANCE))),
	account_history: Some(PruneMode::Distance(MINIMUM_PRUNING_DISTANCE)),
	storage_history: Some(PruneMode::Distance(MINIMUM_PRUNING_DISTANCE)),
	receipts_log_filter: ReceiptsLogPruneConfig(
	chain_spec
	.deposit_contract
	.as_ref()
	.map(|contract| (contract.address, PruneMode::Before(contract.block)))
	.into_iter()
	.collect(),
	),
	},
	}
	}
	// Override with any explicitly set prune.* flags.
	if let Some(mode) = self.sender_recovery_prune_mode() {
	config.segments.sender_recovery = Some(mode);
	}
	if let Some(mode) = self.transaction_lookup_prune_mode() {
	config.segments.transaction_lookup = Some(mode);
	}
	if let Some(mode) = self.receipts_prune_mode() {
	config.segments.receipts = Some(mode);
	}
	if let Some(mode) = self.account_history_prune_mode() {
	config.segments.account_history = Some(mode);
	}
	if let Some(mode) = self.storage_history_prune_mode() {
	config.segments.storage_history = Some(mode);
	}
	Some(config)
	}

was changed, this now no longer returns an optional value

this should remain an option because None is equivalent to "no pruning == archive"

Additional context

imo we can require the full flag for all of these, and return none if no full is set
this shouldn't impact #10774

[emhane]

I don't see the issue, this is exactly what the node builder does - it will end up being the default PruneConfig, same thing method in description returns.

reth/crates/node/builder/src/launch/mod.rs

Line 292 in c258c15

let mut pruner_builder = ctx.pruner_builder();

reth/crates/node/builder/src/launch/common.rs

Lines 359 to 364 in c258c15

	/// Returns an initialized [`PrunerBuilder`] based on the configured [`PruneConfig`]
	pub fn pruner_builder(&self) -> PrunerBuilder {
	PrunerBuilder::new(self.prune_config().unwrap_or_default())
	.delete_limit(self.chain_spec().prune_delete_limit)
	.timeout(PrunerBuilder::DEFAULT_TIMEOUT)
	}