feat(engine): invalid block hooks crate #10629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xey/invalid-block-hook-crate
…xey/invalid-block-hook-crate
rkrasiuk
added
C-enhancement
shekhirin
force-pushed
the
alexey/invalid-block-hook-crate
branch
from
3d4578d
to
773eb4b
Compare
shekhirin
commented
Sep 2, 2024
Comment on lines
209
to
223
| Box::new(InvalidBlockHookChain( | ||
| hook.to_selection() | ||
| .into_iter() | ||
| .map(|hook| match hook { | ||
| reth_node_core::args::InvalidBlockHook::Witness => { | ||
| Ok(Box::new(reth_invalid_block_hooks::witness) | ||
| as Box<dyn InvalidBlockHook>) | ||
| } | ||
| reth_node_core::args::InvalidBlockHook::PreState | | ||
| reth_node_core::args::InvalidBlockHook::Opcode => { | ||
| eyre::bail!("invalid block hook {hook:?} is not implemented yet") | ||
| } | ||
| }) | ||
| .collect::<Result<Vec<_>, _>>()?, | ||
| )) |
There was a problem hiding this comment.
unsure where best to put this logic: we can't have it in the engine crate, as the whole point of decoupling is that we have hooks crate separate from the engine, and we also can't have it in the invalid-block-hooks crate, because the InvalidBlockHook trait lives in the engine crate.
There was a problem hiding this comment.
this should be moved into the LaunchCtx type
shekhirin
requested review from
onbjerg,
gakonst,
DaniPopes,
mattsse,
Rjected,
rkrasiuk and
fgimenez
as code owners
mattsse
requested changes
Sep 3, 2024
Comment on lines
209
to
223
| Box::new(InvalidBlockHookChain( | ||
| hook.to_selection() | ||
| .into_iter() | ||
| .map(|hook| match hook { | ||
| reth_node_core::args::InvalidBlockHook::Witness => { | ||
| Ok(Box::new(reth_invalid_block_hooks::witness) | ||
| as Box<dyn InvalidBlockHook>) | ||
| } | ||
| reth_node_core::args::InvalidBlockHook::PreState | | ||
| reth_node_core::args::InvalidBlockHook::Opcode => { | ||
| eyre::bail!("invalid block hook {hook:?} is not implemented yet") | ||
| } | ||
| }) | ||
| .collect::<Result<Vec<_>, _>>()?, | ||
| )) |
There was a problem hiding this comment.
this should be moved into the LaunchCtx type
mattsse
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10546