feat: add invalid block hook field to tree #10432
Merged
+393
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
force-pushed
the
dan/invalid-block-hook
branch
2 times, most recently
from
f36d88a
to
74ffa2f
Compare
emhane
added
A-consensus
Rjected
force-pushed
the
dan/invalid-block-hook
branch
9 times, most recently
from
2715369
to
61a1f94
Compare
Rjected
force-pushed
the
dan/invalid-block-hook
branch
from
61a1f94
to
beae63b
Compare
Rjected
requested review from
mattsse,
onbjerg,
rkrasiuk,
fgimenez and
gakonst
as code owners
This was referenced Aug 26, 2024
mattsse
requested changes
Aug 27, 2024
shekhirin
force-pushed
the
dan/invalid-block-hook
branch
from
d156cbc
to
a61e345
Compare
shekhirin
changed the title
shekhirin
force-pushed
the
dan/invalid-block-hook
branch
3 times, most recently
from
6db7ae6
to
3ebd86d
Compare
shekhirin
force-pushed
the
dan/invalid-block-hook
branch
from
3ebd86d
to
ec3c090
Compare
shekhirin
changed the title
mattsse
approved these changes
Sep 3, 2024
| @@ -508,6 +510,29 @@ pub struct EngineApiTreeHandler<P, E, T: EngineTypes> { | |||
| config: TreeConfig, | |||
| /// Metrics for the engine api. | |||
| metrics: EngineApiMetrics, | |||
| /// A bad block hook. | |||
| invalid_block_hook: Box<dyn InvalidBlockHook>, | |||
There was a problem hiding this comment.
we could also make this optional, so that it doesn't leak into the new function and use pub set_invalid_block_hook to optionally set one
but can consider doing this when we add a real impl of this
There was a problem hiding this comment.
yep, will address this in #10629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #10425