-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moved optimism_receiptfn and its tests #10520
chore: moved optimism_receiptfn and its tests #10520
Conversation
Can you plz give me command to run and compile these files |
|
moved it to consensus crate @mattsse |
look at the code on main again. it does this #[cfg(feature = "optimism")]
do this
#[cfg(not(feature = "optimism"))]
do other thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, only lint fixes remaining
any command to fix fixed the warning although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think merging main solves those unrelated lint issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are not lint fixes, they are missing imports. please import the missing items to ensure this compiles. the error log shows you what to import from where
the imports are only needed in the test, so add them in there:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed all the blockchaintree deps from consensus, we deprecate this crate soon anyway
99a867a
to
d4a7c51
Compare
Issue
Solves #10514
Moved function and its tests to optimism/primitives