Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved optimism_receiptfn and its tests #10520

Merged

Conversation

Redidacove
Copy link
Contributor

Issue
Solves #10514

Moved function and its tests to optimism/primitives

crates/optimism/primitives/src/proof.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth labels Aug 26, 2024
crates/optimism/primitives/src/proof.rs Outdated Show resolved Hide resolved
crates/optimism/primitives/src/proof.rs Outdated Show resolved Hide resolved
@Redidacove
Copy link
Contributor Author

Can you plz give me command to run and compile these files

@onbjerg
Copy link
Member

onbjerg commented Aug 26, 2024

cargo check --bin op-reth --features optimism should do

crates/optimism/primitives/src/proof.rs Outdated Show resolved Hide resolved
crates/optimism/primitives/src/proof.rs Outdated Show resolved Hide resolved
@Redidacove
Copy link
Contributor Author

moved it to consensus crate @mattsse

@emhane
Copy link
Member

emhane commented Aug 30, 2024

almost there, the test needed to be copied, not moved. the test must run once for non-op once for op

@emhane wdym by run once for non-op and once for op ? I moved it because you said we don't want a dependency in blockchain tree if I dont move it then have to import fn from optimism package

look at the code on main again. it does this

#[cfg(feature = "optimism")]
do this 
#[cfg(not(feature = "optimism"))]
do other thing

@Redidacove Redidacove requested a review from emhane August 31, 2024 05:50
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, only lint fixes remaining

@Redidacove
Copy link
Contributor Author

Redidacove commented Sep 1, 2024

almost there, only lint fixes remaining

any command to fix fixed the warning although

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think merging main solves those unrelated lint issues

onbjerg
onbjerg previously requested changes Sep 2, 2024
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not lint fixes, they are missing imports. please import the missing items to ensure this compiles. the error log shows you what to import from where

the imports are only needed in the test, so add them in there:)

@mattsse mattsse changed the title moved optimism_receiptfn and its tests chore: moved optimism_receiptfn and its tests Sep 5, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed all the blockchaintree deps from consensus, we deprecate this crate soon anyway

@mattsse mattsse force-pushed the feature/moved_optimism_reciept_root branch from 99a867a to d4a7c51 Compare September 5, 2024 12:02
@mattsse mattsse added this pull request to the merge queue Sep 5, 2024
Merged via the queue into paradigmxyz:main with commit 834e99c Sep 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants