Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depedencies via pip extras #2475

Closed
wants to merge 4 commits into from
Closed

Depedencies via pip extras #2475

wants to merge 4 commits into from

Commits on Jul 24, 2024

  1. Record our dependencies using pip extras 

    Flask-Admin does not yet support Flask v3+, WTForms v3+, or SQLAlchemy
2+. Let's clearly mark this.

And then we also define a set of pip extras, which should let users pull
in the supported versions of dependencies for additional features (eg
supporting geography, mapping, redis CLI, exporting to lots of formats,
etc).

And fix our minimum python version from 3.6 to 3.8. This was done a
little while ago, but not updated here correctly.
    @samuelhwilliams
    samuelhwilliams committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0802b4e View commit details
    Browse the repository at this point in the history

  2. Update tox dependencies/setup 

    And pin requirements files again now that we don't include any direct
project dependencies within the `requirements/*` files.
    @samuelhwilliams
    samuelhwilliams committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    46109db View commit details
    Browse the repository at this point in the history

  3. Address test failures after changing how we specify dependencies 

    - Disable `mongoengine` tests. This is the main problem here:
  `Flask-Mongoengine` is now fairly out-of-date and doesn't support
  recent Flask 2.x versions, which our tests try to pull in. With the
  change to how we declare our dependencies (flask), we can't really
  install a specific version of flask that's lower than what we support
  across all of Flask-Admin, which we'd need to do. I don't think we
  want a special case for Flask-Mongoengine. I think we need to accept
  that Flask-Mongoengine is now unsupported and doesn't work with
  Flask-Admin, assuming people are using recent versions of Flask etc.
  We may need to consider deprecating Flask-Mongoengine support
  altogether, but I'm leaving that for a separate issue.

- flask.Markup was removed; use markupsafe instead

- Use BytesIO for file uploads

        rv = client.post('/admin/myfileadmin/upload/',
>                        data=dict(upload=(StringIO(""), 'dummy.txt')))
E       TypeError: a bytes-like object is required, not 'str'

- Update import path

- Ignore deprecation warning from flask.testing

- Flask now requires all routes/views to be registered before the first request

- Werkzeug 2.3.0+ no longer quotes URL params

- Ignore SQLAlchemy2 deprecation warning
    @samuelhwilliams
    samuelhwilliams committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a47560b View commit details
    Browse the repository at this point in the history

  4. Add a snowflake test flow for flaskmongoengine

    @samuelhwilliams
    samuelhwilliams committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    19ba3c8 View commit details
    Browse the repository at this point in the history