Depedencies via pip extras #2475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask-Admin does not yet support Flask v3+, WTForms v3+, or SQLAlchemy 2+. Let's clearly mark this. And then we also define a set of pip extras, which should let users pull in the supported versions of dependencies for additional features (eg supporting geography, mapping, redis CLI, exporting to lots of formats, etc). And fix our minimum python version from 3.6 to 3.8. This was done a little while ago, but not updated here correctly.
And pin requirements files again now that we don't include any direct project dependencies within the `requirements/*` files.
- Disable `mongoengine` tests. This is the main problem here:
`Flask-Mongoengine` is now fairly out-of-date and doesn't support
recent Flask 2.x versions, which our tests try to pull in. With the
change to how we declare our dependencies (flask), we can't really
install a specific version of flask that's lower than what we support
across all of Flask-Admin, which we'd need to do. I don't think we
want a special case for Flask-Mongoengine. I think we need to accept
that Flask-Mongoengine is now unsupported and doesn't work with
Flask-Admin, assuming people are using recent versions of Flask etc.
We may need to consider deprecating Flask-Mongoengine support
altogether, but I'm leaving that for a separate issue.
- flask.Markup was removed; use markupsafe instead
- Use BytesIO for file uploads
rv = client.post('/admin/myfileadmin/upload/',
> data=dict(upload=(StringIO(""), 'dummy.txt')))
E TypeError: a bytes-like object is required, not 'str'
- Update import path
- Ignore deprecation warning from flask.testing
- Flask now requires all routes/views to be registered before the first request
- Werkzeug 2.3.0+ no longer quotes URL params
- Ignore SQLAlchemy2 deprecation warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously haven't ever had a single place that clearly says what dependencies Flask-Admin expects for the 'optional' features, and what versions of those dependencies are required.
This PR pulls all of this information into
pyproject.tomland exposes them as extras.All of the examples have been updated to install using these extras, which simplifies their requirements files.
The controversial change here is that, now, in our 'standard' test runs, we can't get the
flask-mongoenginetests to pass because that dependency is very out of date and doesn't support the latest versions of Flask that we support. We may need to consider deprecating/removingflask-mongoenginealtogether, but I'm leaving that decision to be had on this thread: #2466. I've added a 'snowflake' tox env for flask-mongoengine that pins required (old) versions of flask/werkzeug/sqlalchemy in the mean time.